C++: fix cartesian product in IRGuards.qll

2026-04-28 18:25:24 +02:00 · 2019-03-14 13:37:35 -07:00
parent 6453b05a41
commit dfb7076fae
1 changed files with 1 additions and 3 deletions
--- a/cpp/ql/src/semmle/code/cpp/controlflow/IRGuards.qll
+++ b/cpp/ql/src/semmle/code/cpp/controlflow/IRGuards.qll
@@ -381,9 +381,7 @@ cached class IRGuardCondition extends Instruction {
 }

 private ConditionalBranchInstruction get_branch_for_condition(Instruction guard) {
-  exists(ConditionalBranchInstruction branch|
-    branch.getCondition() = guard
-  )
+  result.getCondition() = guard
  or
  exists(LogicalNotInstruction cond | result = get_branch_for_condition(cond) and cond.getUnary() = guard)
 }