hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

[Java] Add support for com.google.common.base.MoreObjects#firstNonNull

Browse Source
This commit is contained in:
Jonathan Leitschuh
2021-05-03 12:58:00 -04:00
parent b2c0259197
commit dfad1fc740
4 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/ql/src/semmle/code/java/frameworks/guava/Base.qll
View File

@@ -35,7 +35,8 @@ private class GuavaBaseCsv extends SummaryModelCsv {
"com.google.common.base;Splitter;false;splitToList;(CharSequence);;Argument[0];ReturnValue;taint",
"com.google.common.base;Splitter;false;splitToStream;(CharSequence);;Argument[0];ReturnValue;taint",
"com.google.common.base;Splitter$MapSplitter;false;split;(CharSequence);;Argument[0];ReturnValue;taint",
"com.google.common.base;Preconditions;false;checkNotNull;;;Argument[0];ReturnValue;value"
"com.google.common.base;Preconditions;false;checkNotNull;;;Argument[0];ReturnValue;value",
"com.google.common.base;MoreObjects;false;firstNonNull;;;Argument[0..1];ReturnValue;value"
]
}
}

6
java/ql/test/library-tests/frameworks/guava/TestBase.java
View File

@@ -60,4 +60,10 @@ class TestBase {
void test4() {
sink(Preconditions.checkNotNull(taint())); // $numTaintFlow=1
}
void test5() {
sink(MoreObjects.firstNonNull(taint(), taint())); // $numTaintFlow=2
sink(MoreObjects.firstNonNull(null, taint())); // $numTaintFlow=1
sink(MoreObjects.firstNonNull(taint(), null)); // $numTaintFlow=1
}
}

9
java/ql/test/stubs/guava-30.0/com/google/common/base/MoreObjects.java Normal file
View File

@@ -0,0 +1,9 @@
package com.google.common.base;
import org.checkerframework.checker.nullness.qual.Nullable;
public final class MoreObjects {
public static <T> T firstNonNull(@Nullable T first, @Nullable T second) {
return null;
}
}