hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 12:46:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Better IntegerLiteral tracking for weak crypto key

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2021-02-19 14:25:38 +01:00
parent a6583345ba
commit dfa223ac6a
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
python/ql/src/semmle/python/Concepts.qll
View File

@@ -562,6 +562,21 @@ module Cryptography {
/** Provides classes for modeling new key-pair generation APIs. */ /** Provides classes for modeling new key-pair generation APIs. */
module KeyGeneration { module KeyGeneration {
/**
* A data-flow configuration for tracking integer literals.
*/
private class IntegerLiteralTrackerConfiguration extends DataFlow::Configuration {
IntegerLiteralTrackerConfiguration() { this = "IntegerLiteralTrackerConfiguration" }
override predicate isSource(DataFlow::Node source) {
source = DataFlow::exprNode(any(IntegerLiteral size))
}
override predicate isSink(DataFlow::Node sink) {
sink = any(KeyGeneration::Range kg).getKeySizeArg()
}
}
/** /**
* A data-flow node that generates a new key-pair for use with public-key cryptography. * A data-flow node that generates a new key-pair for use with public-key cryptography.
* *
@@ -580,8 +595,9 @@ module Cryptography {
* explains how we obtained this specific key size. * explains how we obtained this specific key size.
*/ */
int getKeySizeWithOrigin(DataFlow::Node origin) { int getKeySizeWithOrigin(DataFlow::Node origin) {
exists(IntegerLiteral size | origin = DataFlow::exprNode(size) | exists(IntegerLiteral size, IntegerLiteralTrackerConfiguration config |
origin.(DataFlow::LocalSourceNode).flowsTo(this.getKeySizeArg()) and origin.asExpr() = size and
config.hasFlow(origin, this.getKeySizeArg()) and
result = size.getValue() result = size.getValue()
) )
} }

1
python/ql/test/query-tests/Security/CWE-326/WeakCryptoKey.expected
View File

@@ -6,3 +6,4 @@
| weak_crypto.py:74:1:74:37 | ControlFlowNode for rsa_gen_key() | Creation of an RSA key uses $@ bits, which is below 2048 and considered breakable. | weak_crypto.py:12:12:12:15 | ControlFlowNode for IntegerLiteral | 1024 | | weak_crypto.py:74:1:74:37 | ControlFlowNode for rsa_gen_key() | Creation of an RSA key uses $@ bits, which is below 2048 and considered breakable. | weak_crypto.py:12:12:12:15 | ControlFlowNode for IntegerLiteral | 1024 |
| weak_crypto.py:76:1:76:22 | ControlFlowNode for Attribute() | Creation of an DSA key uses $@ bits, which is below 2048 and considered breakable. | weak_crypto.py:16:12:16:15 | ControlFlowNode for IntegerLiteral | 1024 | | weak_crypto.py:76:1:76:22 | ControlFlowNode for Attribute() | Creation of an DSA key uses $@ bits, which is below 2048 and considered breakable. | weak_crypto.py:16:12:16:15 | ControlFlowNode for IntegerLiteral | 1024 |
| weak_crypto.py:77:1:77:22 | ControlFlowNode for Attribute() | Creation of an RSA key uses $@ bits, which is below 2048 and considered breakable. | weak_crypto.py:12:12:12:15 | ControlFlowNode for IntegerLiteral | 1024 | | weak_crypto.py:77:1:77:22 | ControlFlowNode for Attribute() | Creation of an RSA key uses $@ bits, which is below 2048 and considered breakable. | weak_crypto.py:12:12:12:15 | ControlFlowNode for IntegerLiteral | 1024 |
| weak_crypto.py:84:12:84:29 | ControlFlowNode for Attribute() | Creation of an RSA key uses $@ bits, which is below 2048 and considered breakable. | weak_crypto.py:12:12:12:15 | ControlFlowNode for IntegerLiteral | 1024 |