hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Remove flow from getAttributeName

Browse Source
This commit is contained in:
Taus Brock-Nannestad
2020-10-08 15:01:24 +02:00
parent ceb249680e
commit df447c0af9
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
python/ql/src/experimental/dataflow/internal/Attributes.qll
View File

@@ -137,12 +137,7 @@ private class SetAttrCallAsAttrWrite extends AttrWrite, CfgNode {
override ExprNode getAttributeNameExpr() { result.asCfgNode() = node.getName() }
override string getAttributeName() {
// TODO track this back using local flow
exists(StrConst s, Node nodeFrom |
s = nodeFrom.asExpr() and
simpleLocalFlowStep*(nodeFrom, this.getAttributeNameExpr()) and
result = s.getText()
)
result = this.getAttributeNameExpr().asExpr().(StrConst).getText()
}
}
@@ -220,10 +215,6 @@ private class GetAttrCallAsAttrRead extends AttrRead, CfgNode {
override ExprNode getAttributeNameExpr() { result.asCfgNode() = node.getName() }
override string getAttributeName() {
exists(StrConst s, Node nodeFrom |
s = nodeFrom.asExpr() and
simpleLocalFlowStep*(nodeFrom, this.getAttributeNameExpr()) and
result = s.getText()
)
result = this.getAttributeNameExpr().asExpr().(StrConst).getText()
}
}