From df3478483487042b9785cd8eb424be45fa68d366 Mon Sep 17 00:00:00 2001 From: Esben Sparre Andreasen Date: Fri, 1 Apr 2022 14:08:58 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Henry Mercer --- .../test/generic_feature_testing/NonFunctionalFeature.ql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/ql/experimental/adaptivethreatmodeling/test/generic_feature_testing/NonFunctionalFeature.ql b/javascript/ql/experimental/adaptivethreatmodeling/test/generic_feature_testing/NonFunctionalFeature.ql index 4cb91db06af..6401e161fd1 100644 --- a/javascript/ql/experimental/adaptivethreatmodeling/test/generic_feature_testing/NonFunctionalFeature.ql +++ b/javascript/ql/experimental/adaptivethreatmodeling/test/generic_feature_testing/NonFunctionalFeature.ql @@ -2,7 +2,7 @@ import javascript import experimental.adaptivethreatmodeling.EndpointFeatures import TestUtil -// every feature must produce a single value for each endpoint that it computes a value for, otherwise the ML model will be confused(?) +// every feature must produce a single value for each endpoint that it computes a value for, per the contract of the `scoreEndpoints` HOP from Endpoint endpoint, EndpointFeature feature, int arity where arity = count(feature.getValue(endpoint)) and arity > 1 select endpoint, feature.getName(), arity