From dd9738f9a693f57884efdcc0c3f83a2ef4284d06 Mon Sep 17 00:00:00 2001 From: Max Schaefer Date: Tue, 14 Apr 2020 16:07:23 +0100 Subject: [PATCH] Better fix for frontend errors in `DeadStoreOfLocal` tests. --- .../DeadStoreOfLocal/DeadStoreOfLocal.expected | 13 +++++++------ .../RedundantCode/DeadStoreOfLocal/testdata.go | 3 ++- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/DeadStoreOfLocal.expected b/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/DeadStoreOfLocal.expected index 9225c76f858..b646631be51 100644 --- a/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/DeadStoreOfLocal.expected +++ b/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/DeadStoreOfLocal.expected @@ -20,9 +20,10 @@ | testdata.go:268:2:268:2 | assignment to x | This definition of x is never used. | | testdata.go:309:2:309:2 | assignment to a | This definition of a is never used. | | testdata.go:321:2:321:2 | assignment to a | This definition of a is never used. | -| testdata.go:431:3:431:3 | assignment to x | This definition of x is never used. | -| testdata.go:433:3:433:3 | assignment to x | This definition of x is never used. | -| testdata.go:440:2:440:2 | assignment to x | This definition of x is never used. | -| testdata.go:487:3:487:3 | assignment to x | This definition of x is never used. | -| testdata.go:541:3:541:3 | assignment to x | This definition of x is never used. | -| testdata.go:579:4:579:4 | assignment to x | This definition of x is never used. | +| testdata.go:387:3:387:3 | assignment to x | This definition of x is never used. | +| testdata.go:432:3:432:3 | assignment to x | This definition of x is never used. | +| testdata.go:434:3:434:3 | assignment to x | This definition of x is never used. | +| testdata.go:441:2:441:2 | assignment to x | This definition of x is never used. | +| testdata.go:488:3:488:3 | assignment to x | This definition of x is never used. | +| testdata.go:542:3:542:3 | assignment to x | This definition of x is never used. | +| testdata.go:580:4:580:4 | assignment to x | This definition of x is never used. | diff --git a/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/testdata.go b/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/testdata.go index 94f59821ceb..031ba35aa44 100644 --- a/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/testdata.go +++ b/ql/test/query-tests/RedundantCode/DeadStoreOfLocal/testdata.go @@ -381,11 +381,12 @@ func _() { func _() { var x int switch b { + case true: + _ = x default: x = deadStore() // BAD fallthrough case b: - _ = x } }