mirror of
https://github.com/github/codeql.git
synced 2026-04-26 01:05:15 +02:00
Crypto: Adjust output of bad mac order queries, update associated bad mac order expected results, fix erroneous change to ID for a slicing query, update model to specify elliptic curve type as a property, update associated graph test expected files, update the not_included_in_qls.expected to reflect all queries now under quantum.
This commit is contained in:
@@ -15,4 +15,4 @@ import BadMacOrder
|
||||
from ArtifactFlow::PathNode src, ArtifactFlow::PathNode sink
|
||||
where isDecryptToMacFlow(src, sink)
|
||||
select sink, src, sink,
|
||||
"MAC order potentially wrong: observed a potential decrypt operation output to MAC implying the MAC is on plaintext, and not a cipher."
|
||||
"Incorrect decryption and MAC order: decryption output plaintext flows to MAC message input."
|
||||
|
||||
@@ -17,5 +17,5 @@ from
|
||||
PlaintextUseAsMacAndCipherInputFlow::PathNode sink, InterimArg arg
|
||||
where isPlaintextInEncryptionAndMac(src, sink, arg)
|
||||
select sink, src, sink,
|
||||
"Source is used as plaintext to MAC and encryption operation. Indicates possible misuse of MAC. Path shows plaintext to final use through intermediate mac or encryption operation here $@",
|
||||
"Incorrect MAC usage: Encryption plaintext also used for MAC. Flow shows plaintext to final use through intermediate mac or encryption operation here $@",
|
||||
arg.asExpr(), arg.asExpr().toString()
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
/**
|
||||
* @name Operations with unknown algorithm
|
||||
* @description Outputs operations where the algorithm applied is unknown
|
||||
* @id java/quantum/examples/slices/operation-with-unknown-algorithm
|
||||
* @id java/quantum/slices/operation-with-unknown-algorithm
|
||||
* @kind problem
|
||||
* @severity info
|
||||
* @tags quantum
|
||||
|
||||
Reference in New Issue
Block a user