From dd548945c79a4520367538f083cbb15263635fb2 Mon Sep 17 00:00:00 2001 From: Kasper Svendsen Date: Thu, 29 Jun 2023 14:25:44 +0200 Subject: [PATCH] Enable checks for implicit this warnings --- .github/workflows/check-implicit-this.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check-implicit-this.yml b/.github/workflows/check-implicit-this.yml index 8539c7b3330..8711d7955bc 100644 --- a/.github/workflows/check-implicit-this.yml +++ b/.github/workflows/check-implicit-this.yml @@ -1,6 +1,13 @@ name: "Check implicit this warnings" -on: workflow_dispatch +on: + workflow_dispatch: + pull_request: + paths: + - "**qlpack.yml" + branches: + - main + - "rc/*" jobs: check: @@ -15,7 +22,7 @@ jobs: for pack_file in ${packs}; do option="$(yq '.warnOnImplicitThis' ${pack_file})" if [ "${option}" != "true" ]; then - echo "warnOnImplicitThis property must be set to 'true' for pack ${pack_file}" + echo "::error file=${pack_file}::warnOnImplicitThis property must be set to 'true' for pack ${pack_file}" EXIT_CODE=1 fi done