hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 19:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Code review suggestion

Browse Source
This commit is contained in:
Tom Hvitved
2022-08-03 10:41:44 +02:00
committed by Tamas Vajk
parent 36c913061c
commit dd465e739b
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowDispatch.qll
View File

@@ -4,7 +4,6 @@ private import dotnet
private import DataFlowImplCommon as DataFlowImplCommon
private import DataFlowPublic
private import DataFlowPrivate
private import semmle.code.csharp.controlflow.internal.Splitting
private import FlowSummaryImpl as FlowSummaryImpl
private import semmle.code.csharp.dataflow.FlowSummary as FlowSummary
private import semmle.code.csharp.dataflow.ExternalFlow
@@ -22,7 +21,13 @@ private import semmle.code.csharp.frameworks.system.collections.Generic
*/
DotNet::Callable getCallableForDataFlow(DotNet::Callable c) {
exists(DotNet::Callable unboundDecl | unboundDecl = c.getUnboundDeclaration() |
result.hasBody() and
(
result.hasBody()
or
// take synthesized bodies into account, e.g. implicit constructors
// with field initializer assignments
result = any(ControlFlow::Nodes::ElementNode n).getEnclosingCallable()
) and
if unboundDecl.getFile().fromSource()
then
// C# callable with C# implementation in the database
@@ -40,16 +45,6 @@ DotNet::Callable getCallableForDataFlow(DotNet::Callable c) {
// C# callable without C# implementation in the database
unboundDecl.matchesHandle(result.(CIL::Callable))
)
or
result = c.getUnboundDeclaration() and
isDefaultConstructorWithMemberInit(result)
}
private predicate isDefaultConstructorWithMemberInit(InstanceConstructor c) {
c.isUnboundDeclaration() and
c.getFile().fromSource() and
not c.hasBody() and
InitializerSplitting::constructorInitializes(c, _)
}
/**