hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

(Refactor) Make lookThroughImplicitFieldRead public

Browse Source
This commit is contained in:
Owen Mansel-Chan
2025-11-26 10:17:49 +00:00
parent 9bf20702c6
commit dcfa721037
2 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
go/ql/lib/semmle/go/controlflow/IR.qll
View File

@@ -1588,4 +1588,9 @@ module IR {
* in a field/method access, element access, or slice expression. * in a field/method access, element access, or slice expression.
*/ */
EvalImplicitDerefInstruction implicitDerefInstruction(Expr e) { result = MkImplicitDeref(e) } EvalImplicitDerefInstruction implicitDerefInstruction(Expr e) { result = MkImplicitDeref(e) }
/** Gets the base of `insn`, if `insn` is an implicit field read. */
Instruction lookThroughImplicitFieldRead(Instruction insn) {
result = insn.(ImplicitFieldReadInstruction).getBaseInstruction()
}
} }

16
go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImpl.qll
View File

@@ -384,17 +384,13 @@ module SourceSinkInterpretationInput implements
} }
private DataFlow::Node skipImplicitFieldReads(DataFlow::Node n) { private DataFlow::Node skipImplicitFieldReads(DataFlow::Node n) {
not exists(lookThroughImplicitFieldRead(n)) and result = n not exists(IR::lookThroughImplicitFieldRead(n.asInstruction())) and result = n
or or
result = skipImplicitFieldReads(lookThroughImplicitFieldRead(n)) exists(DataFlow::Node mid |
} mid.asInstruction() = IR::lookThroughImplicitFieldRead(n.asInstruction())
|
private DataFlow::Node lookThroughImplicitFieldRead(DataFlow::Node n) { result = skipImplicitFieldReads(mid)
result.asInstruction() = )
n.(DataFlow::InstructionNode)
.asInstruction()
.(IR::ImplicitFieldReadInstruction)
.getBaseInstruction()
} }
/** Provides additional sink specification logic. */ /** Provides additional sink specification logic. */