hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Simplify a bit and remove two noopts that don't seem to make a difference.

Browse Source
This commit is contained in:
Geoffrey White
2021-06-29 18:16:29 +01:00
parent 5bf7e453e6
commit dcc7a6360f
1 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.ql
View File

@@ -19,17 +19,10 @@ import cpp
* Holds if the argument corresponding to the `pos` conversion specifier
* of `ffc` is expected to have type `expected`.
*/
pragma[noopt]
private predicate formattingFunctionCallExpectedType(
FormattingFunctionCall ffc, int pos, Type expected
) {
exists(FormattingFunction f, int i, FormatLiteral fl |
ffc instanceof FormattingFunctionCall and
ffc.getTarget() = f and
f.getFormatParameterIndex() = i and
ffc.getArgument(i) = fl and
fl.getConversionType(pos) = expected
)
ffc.getFormat().(FormatLiteral).getConversionType(pos) = expected
}
/**
@@ -37,17 +30,10 @@ private predicate formattingFunctionCallExpectedType(
* of `ffc` could alternatively have type `expected`, for example on a different
* platform.
*/
pragma[noopt]
private predicate formattingFunctionCallAlternateType(
FormattingFunctionCall ffc, int pos, Type expected
) {
exists(FormattingFunction f, int i, FormatLiteral fl |
ffc instanceof FormattingFunctionCall and
ffc.getTarget() = f and
f.getFormatParameterIndex() = i and
ffc.getArgument(i) = fl and
fl.getConversionTypeAlternate(pos) = expected
)
ffc.getFormat().(FormatLiteral).getConversionTypeAlternate(pos) = expected
}
/**