hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Replace getUnderlyingType().getUnspecifiedType()

Browse Source
This commit is contained in:
Robert Marsh
2019-05-20 15:23:08 +01:00
parent e899120270
commit dbdaa1d3f3
10 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/Best Practices/Exceptions/CatchingByValue.ql
View File

@@ -13,6 +13,6 @@
import cpp
from CatchBlock cb, Class caughtType
where caughtType = cb.getParameter().getType().getUnderlyingType().getUnspecifiedType()
where caughtType = cb.getParameter().getUnspecifiedType()
select cb,
"This should catch a " + caughtType.getName() + " by (const) reference rather than by value."

2
cpp/ql/src/Best Practices/Unused Entities/UnusedLocals.ql
View File

@@ -40,7 +40,7 @@ class TemplateDependentType extends Type {
* A variable whose declaration has, or may have, side effects.
*/
predicate declarationHasSideEffects(Variable v) {
exists(Class c | c = v.getType().getUnderlyingType().getUnspecifiedType() |
exists(Class c | c = v.getUnspecifiedType() |
c.hasConstructor() or
c.hasDestructor()
)

2
cpp/ql/src/Best Practices/Unused Entities/UnusedStaticVariables.ql
View File

@@ -14,7 +14,7 @@
import cpp
predicate declarationHasSideEffects(Variable v) {
exists(Class c | c = v.getType().getUnderlyingType().getUnspecifiedType() |
exists(Class c | c = v.getUnspecifiedType() |
c.hasConstructor() or c.hasDestructor()
)
}