Python: move tests to data extensions

For these tests, we cannot use the same mechanism, as we want the
data extensions to be available for both tests.

Instead, we create a ql-pack for the test directory and point to
the data entensions from there. This makes the extensions
available for all tests in the directory.

codeql-workspace.yml

@@ -27,6 +27,7 @@ provide:
   - "swift/extractor-pack/codeql-extractor.yml"
   - "swift/integration-tests/qlpack.yml"
   - "ql/extractor-pack/codeql-extractor.yml"
+  - "python/ql/test/experimental/dataflow/model-summaries/qlpack.yml"
 
 versionPolicies:
   default:

python/ql/test/experimental/dataflow/model-summaries/AllTests.ext.yml

@@ -0,0 +1,18 @@
+extensions:
+  - addsTo:
+      pack: codeql/python-all
+      extensible: summaryModel
+    data:
+      - ["foo", "Member[MS_identity]", "Argument[0]", "ReturnValue", "value"]
+      - ["foo", "Member[MS_apply_lambda]", "Argument[1]", "Argument[0].Parameter[0]", "value"]
+      - ["foo", "Member[MS_apply_lambda]", "Argument[0].ReturnValue", "ReturnValue", "value"]
+      - ["foo", "Member[MS_reversed]", "Argument[0].ListElement", "ReturnValue.ListElement", "value"]
+      - ["foo", "Member[MS_reversed]", "Argument[0]", "ReturnValue", "taint"]
+      - ["foo", "Member[MS_list_map]", "Argument[1].ListElement", "Argument[0].Parameter[0]", "value"]
+      - ["foo", "Member[MS_list_map]", "Argument[0].ReturnValue", "ReturnValue.ListElement", "value"]
+      - ["foo", "Member[MS_list_map]", "Argument[1]", "ReturnValue", "taint"]
+      - ["foo", "Member[MS_append_to_list]", "Argument[0].ListElement", "ReturnValue.ListElement", "value"]
+      - ["foo", "Member[MS_append_to_list]", "Argument[1]", "ReturnValue.ListElement", "value"]
+      - ["foo", "Member[MS_append_to_list]", "Argument[0]", "ReturnValue", "taint"]
+      - ["foo", "Member[MS_append_to_list]", "Argument[1]", "ReturnValue", "taint"]
+      - ["json", "Member[MS_loads]", "Argument[0]", "ReturnValue", "taint"]

python/ql/test/experimental/dataflow/model-summaries/InlineTaintTest.ql

@@ -1,4 +1,3 @@
 import python
-private import TestSummaries
 import experimental.meta.InlineTaintTest
 import MakeInlineTaintTest<TestTaintTrackingConfig>

python/ql/test/experimental/dataflow/model-summaries/NormalDataflowTest.ql

@@ -1,3 +1,2 @@
 import python
-private import TestSummaries
 import experimental.dataflow.TestUtil.NormalDataflowTest

python/ql/test/experimental/dataflow/model-summaries/TestSummaries.qll

@@ -1,25 +0,0 @@
-private import python
-private import semmle.python.dataflow.new.FlowSummary
-private import semmle.python.frameworks.data.ModelsAsData
-private import semmle.python.ApiGraphs
-
-private class StepsFromModel extends ModelInput::SummaryModelCsv {
-  override predicate row(string row) {
-    row =
-      [
-        "foo;Member[MS_identity];Argument[0];ReturnValue;value",
-        "foo;Member[MS_apply_lambda];Argument[1];Argument[0].Parameter[0];value",
-        "foo;Member[MS_apply_lambda];Argument[0].ReturnValue;ReturnValue;value",
-        "foo;Member[MS_reversed];Argument[0].ListElement;ReturnValue.ListElement;value",
-        "foo;Member[MS_reversed];Argument[0];ReturnValue;taint",
-        "foo;Member[MS_list_map];Argument[1].ListElement;Argument[0].Parameter[0];value",
-        "foo;Member[MS_list_map];Argument[0].ReturnValue;ReturnValue.ListElement;value",
-        "foo;Member[MS_list_map];Argument[1];ReturnValue;taint",
-        "foo;Member[MS_append_to_list];Argument[0].ListElement;ReturnValue.ListElement;value",
-        "foo;Member[MS_append_to_list];Argument[1];ReturnValue.ListElement;value",
-        "foo;Member[MS_append_to_list];Argument[0];ReturnValue;taint",
-        "foo;Member[MS_append_to_list];Argument[1];ReturnValue;taint",
-        "json;Member[MS_loads];Argument[0];ReturnValue;taint"
-      ]
-  }
-}

python/ql/test/experimental/dataflow/model-summaries/qlpack.yml

@@ -0,0 +1,11 @@
+name: python-model-summaries-tests
+groups:
+    - python
+    - test
+dependencies:
+    codeql/python-tests: ${workspace}
+extractor: python
+tests: .
+warnOnImplicitThis: true
+dataExtensions:
+  - AllTests.ext.yml