hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Take into account that the 4th argument of openat may be omitted

Browse Source 
This matches what is done for `open`.
This commit is contained in:
Jeroen Ketema
2022-02-01 11:41:07 +01:00
parent 8df04c58e9
commit dbac927721
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/src/Security/CWE/CWE-732/FilePermissions.qll
View File

@@ -111,12 +111,18 @@ class CreatCreationExpr extends FileCreationExpr {
class OpenatCreationExpr extends FileCreationExpr {
OpenatCreationExpr() {
this.getTarget().getName() = "openat" and
this.getNumberOfArguments() = 4
sets(this.getArgument(2).getValue().toInt(), o_creat())
}
override Expr getPath() { result = this.getArgument(1) }
override int getMode() { result = this.getArgument(3).getValue().toInt() }
override int getMode() {
if exists(this.getArgument(3))
then result = this.getArgument(3).getValue().toInt()
else
// assume anything is permitted
result = 0.bitNot()
}
}
private int fopenMode() {