hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 08:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Move some alerts and add query IDs

Browse Source
This commit is contained in:
Asger F
2025-02-25 16:22:04 +01:00
parent c79d355d26
commit db98dc6272
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
javascript/ql/test/query-tests/Security/CWE-830/DynamicCreationOfUntrustedSourceUse.html
View File

@@ -13,25 +13,25 @@
scrpt2.src = 'http://www.cdn.local/ga.js';
scrpt2.integrity = 'sha256-h0UuK3mE9taiYlB5u9vT9A0s/XDgkfVd+F4VhN/sky=';
var scrpt3 = document.createElement('script'); // $ Alert - http + ternary
var scrpt3 = document.createElement('script');
scrpt3.type = 'text/javascript';
scrpt3.src = ('https:' == document.location.protocol ? 'http://unsafe' : 'http://also-unsafe') + '.cdn.local/ga.js';
scrpt3.src = ('https:' == document.location.protocol ? 'http://unsafe' : 'http://also-unsafe') + '.cdn.local/ga.js'; // $ Alert[js/functionality-from-untrusted-source] - http + ternary
var ifrm = document.createElement('iframe'); // $ Alert - http URL
ifrm.src = 'http://www.example.com/';
var ifrm = document.createElement('iframe');
ifrm.src = 'http://www.example.com/'; // $ Alert[js/functionality-from-untrusted-source] - http URL
// OK - https URL
var ifrm2 = document.createElement('iframe');
ifrm2.src = 'https://www.example.com/';
function getUrl(version) { // $ Alert - http URL tracked through calls
function getUrl(version) {
return 'http://www.cdn.local/'+version+'/ga.js';
}
var ifrm3 = document.createElement('iframe');
ifrm3.src = getUrl('v123');
ifrm3.src = getUrl('v123'); // $ Alert[js/functionality-from-untrusted-source] - http URL tracked through calls
var ifrm4 = document.createElement('iframe'); // $ Alert - assignment of bad URL using setAttribute
ifrm4.setAttribute('src', 'http://www.example.local/page.html');
var ifrm4 = document.createElement('iframe');
ifrm4.setAttribute('src', 'http://www.example.local/page.html'); // $ Alert[js/functionality-from-untrusted-source] - assignment of bad URL using setAttribute
// OK - bad URL, but the attribute is not `src`
var ifrm5 = document.createElement('iframe');
@@ -42,4 +42,4 @@
<body>
hello
</body>
</html>
</html>

2
javascript/ql/test/query-tests/Security/CWE-830/StaticCreationOfUntrustedSourceUse.html
View File

@@ -17,6 +17,6 @@
<!-- Some CDNs recommend using the integrity attribute — for those, we demand it even with https links -->
<!-- OK - digest present -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.8.2/angular.min.js" integrity="sha512-7oYXeK0OxTFxndh0erL8FsjGvrl2VMDor6fVqzlLGfwOQQqTbYsGPv4ZZ15QHfSk80doyaM0ZJdvkyDcVO7KFA==" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.8.2/angular.min.js" crossorigin="anonymous" referrerpolicy="no-referrer"></script> <!-- $ Alert - digest missing -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.8.2/angular.min.js" crossorigin="anonymous" referrerpolicy="no-referrer"></script> <!-- $ Alert[js/functionality-from-untrusted-source] - digest missing -->
</body>
</html>