hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Add test for macro exclusions

Browse Source
This commit is contained in:
Jonas Jensen
2019-11-13 14:17:20 +01:00
parent 8d79634f8c
commit db33053422
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/test/query-tests/Likely Bugs/Memory Management/PointerOverflow/PointerOverflow.expected
View File

@@ -1,2 +1,4 @@
| test.cpp:6:12:6:33 | ... < ... | Range check relying on pointer overflow. |
| test.cpp:33:9:33:21 | ... < ... | Range check relying on pointer overflow. |
| test.cpp:49:36:49:48 | ... < ... | Range check relying on pointer overflow. |
| test.cpp:51:14:51:26 | ... < ... | Range check relying on pointer overflow. |

16
cpp/ql/test/query-tests/Likely Bugs/Memory Management/PointerOverflow/test.cpp
View File

@@ -40,3 +40,19 @@ bool not_in_range_good(Q *ptr, Q *ptr_end, size_t a) {
bool in_range(Q *ptr, Q *ptr_end, size_t a) {
return a < ptr_end - ptr; // GOOD
}
extern "C" void abort(void);
#define MYASSERT(cond) if (cond) abort()
void assert_not_in_range_bad(Q *ptr, Q *ptr_end, size_t a) {
MYASSERT(ptr + a >= ptr_end || ptr + a < ptr); // BAD
MYASSERT(ptr + a >= ptr_end); // GOOD (for the purpose of this test)
MYASSERT(ptr + a < ptr); // BAD
}
#define IS_LESS_THAN(lhs, rhs) ((lhs) < (rhs))
bool not_in_range_macro(Q *ptr, Q *ptr_end, size_t a) {
return ptr + a >= ptr_end || IS_LESS_THAN(ptr + a, ptr); // GOOD (meant to be excluded)
}