hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Allow callables to connect to calls freely

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2020-10-01 12:33:42 +02:00
parent b092df48a5
commit db23dad6ec
2 changed files with 23 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
python/ql/src/experimental/dataflow/internal/DataFlowPrivate.qll
View File

@@ -270,11 +270,18 @@ module ArgumentPassing {
)
}
predicate connects(CallNode call, CallableValue callable) {
exists(DataFlowCall c |
call = c.getNode() and
callable = c.getCallable().getCallableValue()
)
}
/**
* Gets the argument to `call` that is passed to the `n`th parameter of `callable`.
*/
Node getArg(CallNode call, CallableValue callable, int n) {
call = callable.getACall() and
connects(call, callable) and
(
// positional argument
result = TCfgNode(call.getArg(n))
@@ -287,20 +294,14 @@ module ArgumentPassing {
)
or
// a synthezised argument passed to the starred parameter (at position -1)
exists(Function f |
f = callable.getScope() and
f.hasVarArg() and
n = -1 and
result = TPosOverflowNode(call, callable)
)
callable.getScope().hasVarArg() and
n = -1 and
result = TPosOverflowNode(call, callable)
or
// a synthezised argument passed to the doubly starred parameter (at position -2)
exists(Function f |
f = callable.getScope() and
f.hasKwArg() and
n = -2 and
result = TKwOverflowNode(call, callable)
)
callable.getScope().hasKwArg() and
n = -2 and
result = TKwOverflowNode(call, callable)
or
// argument unpacked from dict
exists(string name |
@@ -312,7 +313,7 @@ module ArgumentPassing {
/** Gets the control flow node that is passed as the `n`th overflow positional argument. */
ControlFlowNode getPositionalOverflowArg(CallNode call, CallableValue callable, int n) {
call = callable.getACall() and
connects(call, callable) and
exists(Function f, int posCount, int argNr |
f = callable.getScope() and
f.hasVarArg() and
@@ -325,7 +326,7 @@ module ArgumentPassing {
/** Gets the control flow node that is passed as the overflow keyword argument with key `key`. */
ControlFlowNode getKeywordOverflowArg(CallNode call, CallableValue callable, string key) {
call = callable.getACall() and
connects(call, callable) and
exists(Function f |
f = callable.getScope() and
f.hasKwArg() and
@@ -339,7 +340,7 @@ module ArgumentPassing {
* It will then be passed to the `n`th parameter of `callable`.
*/
predicate call_unpacks(CallNode call, CallableValue callable, string name, int n) {
call = callable.getACall() and
connects(call, callable) and
exists(Function f |
f = callable.getScope() and
not exists(call.getArg(n)) and // no positional arguement available