hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix the alwaysHasNoEffect predicate, and rename it to lastStatementHasNoEffect

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2019-10-22 09:37:19 +02:00
parent 2e0244cda6
commit db22916850
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
javascript/ql/src/Statements/UseOfReturnlessFunction.ql
View File

@@ -85,11 +85,11 @@ predicate alwaysThrows(Function f) {
/**
* Holds if the last statement in the function is flagged by the js/useless-expression query.
*/
predicate alwaysHasNoEffect(Function f) {
exists(ReachableBasicBlock entry, DataFlow::Node noEffect |
entry = f.getEntryBB() and
hasNoEffect(noEffect.asExpr()) and
entry.dominates(noEffect.getBasicBlock())
predicate lastStatementHasNoEffect(Function f) {
exists(DataFlow::Node noEffect |
noEffect.getContainer() = f and
hasNoEffect(noEffect.asExpr()) and
not exists(noEffect.getASuccessor())
)
}
@@ -155,7 +155,7 @@ where
name = "callback function"
) and
not benignContext(call.asExpr()) and
not alwaysHasNoEffect(func) and
not lastStatementHasNoEffect(func) and
// anonymous one-shot closure. Those are used in weird ways and we ignore them.
not oneshotClosure(call.asExpr())
select