From db1b69868948058cfec0ef14e7beed166f4f736c Mon Sep 17 00:00:00 2001 From: Simon Friis Vindum Date: Mon, 11 Nov 2024 08:59:34 +0100 Subject: [PATCH] Rust: Accept fixed spurious results --- .../unusedentities/CONSISTENCY/DataFlowConsistency.expected | 3 +++ rust/ql/test/query-tests/unusedentities/UnusedValue.expected | 2 -- rust/ql/test/query-tests/unusedentities/unreachable.rs | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/rust/ql/test/query-tests/unusedentities/CONSISTENCY/DataFlowConsistency.expected b/rust/ql/test/query-tests/unusedentities/CONSISTENCY/DataFlowConsistency.expected index b59b965efa1..d0187119e01 100644 --- a/rust/ql/test/query-tests/unusedentities/CONSISTENCY/DataFlowConsistency.expected +++ b/rust/ql/test/query-tests/unusedentities/CONSISTENCY/DataFlowConsistency.expected @@ -218,6 +218,9 @@ uniqueCallEnclosingCallable | unreachable.rs:294:13:294:32 | CallExpr | Call should have one enclosing callable but has 0. | | unreachable.rs:296:9:296:22 | CallExpr | Call should have one enclosing callable but has 0. | | unreachable.rs:301:13:301:32 | CallExpr | Call should have one enclosing callable but has 0. | +| unreachable.rs:306:5:306:18 | CallExpr | Call should have one enclosing callable but has 0. | +| unreachable.rs:308:5:308:18 | CallExpr | Call should have one enclosing callable but has 0. | +| unreachable.rs:310:5:310:18 | CallExpr | Call should have one enclosing callable but has 0. | | unreachable.rs:318:22:318:41 | CallExpr | Call should have one enclosing callable but has 0. | | unreachable.rs:319:9:319:22 | CallExpr | Call should have one enclosing callable but has 0. | | unreachable.rs:322:9:322:22 | CallExpr | Call should have one enclosing callable but has 0. | diff --git a/rust/ql/test/query-tests/unusedentities/UnusedValue.expected b/rust/ql/test/query-tests/unusedentities/UnusedValue.expected index 6eebfc870bf..f8538e5b8bc 100644 --- a/rust/ql/test/query-tests/unusedentities/UnusedValue.expected +++ b/rust/ql/test/query-tests/unusedentities/UnusedValue.expected @@ -18,5 +18,3 @@ | more.rs:44:9:44:14 | a_ptr4 | Variable $@ is assigned a value that is never used. | more.rs:44:9:44:14 | a_ptr4 | a_ptr4 | | more.rs:59:9:59:13 | d_ptr | Variable $@ is assigned a value that is never used. | more.rs:59:9:59:13 | d_ptr | d_ptr | | more.rs:65:9:65:17 | f_ptr | Variable $@ is assigned a value that is never used. | more.rs:65:13:65:17 | f_ptr | f_ptr | -| unreachable.rs:292:9:292:15 | for_ten | Variable $@ is assigned a value that is never used. | unreachable.rs:292:9:292:15 | for_ten | for_ten | -| unreachable.rs:299:9:299:16 | for_ever | Variable $@ is assigned a value that is never used. | unreachable.rs:299:9:299:16 | for_ever | for_ever | diff --git a/rust/ql/test/query-tests/unusedentities/unreachable.rs b/rust/ql/test/query-tests/unusedentities/unreachable.rs index 5f26863b625..f55459a0e6e 100644 --- a/rust/ql/test/query-tests/unusedentities/unreachable.rs +++ b/rust/ql/test/query-tests/unusedentities/unreachable.rs @@ -289,14 +289,14 @@ pub fn unreachable_loop() { async fn do_something_async() {} pub async fn unreachable_loop_async() { - let for_ten = async { // $ SPURIOUS: Alert[rust/unused-value] + let for_ten = async { for _ in 1..10 { do_something_async().await; } do_something(); }; - let for_ever = async { // $ SPURIOUS: Alert[rust/unused-value] + let for_ever = async { loop { do_something_async().await; }