hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 02:35:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: support property tracking of custom abstract values

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-11-13 11:29:35 +01:00
parent 1d87c580b3
commit daed0653cb
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/ql/src/semmle/javascript/dataflow/internal/AbstractPropertiesImpl.qll
View File

@@ -77,5 +77,6 @@ predicate shouldAlwaysTrackProperties(AbstractValue baseVal) {
predicate shouldTrackProperties(AbstractValue baseVal) {
shouldAlwaysTrackProperties(baseVal) or
baseVal instanceof AbstractObjectLiteral or
baseVal instanceof AbstractInstance
baseVal instanceof AbstractInstance or
baseVal.(DefinedCustomAbstractValue).shouldTrackProperties()
}

3
javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll
View File

@@ -14,7 +14,8 @@ import semmle.javascript.dataflow.Configuration
*/
predicate shouldTrackProperties(AbstractValue obj) {
obj instanceof AbstractExportsObject or
obj instanceof AbstractModuleObject
obj instanceof AbstractModuleObject or
obj.(DefinedCustomAbstractValue).shouldTrackProperties()
}
/**

2
javascript/ql/test/library-tests/DefinedCustomAbstractValue/DefinedCustomAbstractValue.expected
View File

@@ -1,2 +1,2 @@
| tst.js:4:16:4:50 | { custo ... false } | tst.js:4:16:4:50 | { custo ... false } | false | false |
| tst.js:5:16:5:49 | { custo ... true } | tst.js:5:16:5:49 | { custo ... true } | false | false |
| tst.js:5:16:5:49 | { custo ... true } | tst.js:5:16:5:49 | { custo ... true } | true | true |