hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 19:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
This commit is contained in:
Geoffrey White
2025-04-07 14:27:12 +01:00
committed by GitHub
parent 893e42315e
commit dad85854cd
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
rust/ql/src/queries/security/CWE-770/UncontrolledAllocationSize.qhelp
View File

@@ -5,11 +5,11 @@
<overview> <overview>
<p>Allocating memory with a size based on user input may allow arbitrary amounts of memory to be <p>Allocating memory with a size based on user input may allow arbitrary amounts of memory to be
allocated, leading to a crash or denial of service incident.</p> allocated, leading to a crash or a denial-of-service (DoS) attack.</p>
<p>If the user input is multiplied by a constant, such as the size of a type, the result may <p>If the user input is multiplied by a constant, such as the size of a type, the result may
overflow. In a build with the <code>--release</code> flag Rust performs two's complement wrapping, overflow. In a build with the <code>--release</code> flag, Rust performs two's complement wrapping,
with the result that less memory may be allocated than expected. This can lead to buffer overflow with the result that less memory than expected may be allocated. This can lead to buffer overflow
incidents.</p> incidents.</p>
</overview> </overview>
@@ -24,12 +24,12 @@ does not wrap around.</p>
<example> <example>
<p>In the following example, an arbitrary amount of memory is allocated based on user input. In <p>In the following example, an arbitrary amount of memory is allocated based on user input. In
addition, due to the multiplication operation the result may overflow if a very large value is addition, due to the multiplication operation, the result may overflow if a very large value is
provided, leading to less memory being allocated than other parts of the program expect.</p> provided. This may lead to less memory being allocated than expected by other parts of the program.</p>
<sample src="UncontrolledAllocationSizeBad.rs" /> <sample src="UncontrolledAllocationSizeBad.rs" />
<p>In the fixed example, the user input is checked against a maximum value. If the check fails an <p>In the fixed example, the user input is checked against a maximum value. If the check fails, an
error is returned, and both the multiplication and alloaction do not take place.</p> error is returned, and both the multiplication and allocation do not take place.</p>
<sample src="UncontrolledAllocationSizeGood.rs" /> <sample src="UncontrolledAllocationSizeGood.rs" />
</example> </example>