hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 02:44:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add support for android:allowBackup default value

Browse Source 
The default value of `android:allowBackup` is `true`. Added support for
detecting if the default value is used.
This commit is contained in:
Ed Minnix
2022-08-18 22:04:38 -04:00
parent 6509426fb3
commit dad4a403db
3 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/Security/CWE/CWE-312/AllowBackupAttributeEnabled.ql
View File

@@ -17,4 +17,4 @@ from AndroidApplicationXmlElement androidAppElem
where
androidAppElem.allowsBackup() and
androidAppElem.getFile().(AndroidManifestXmlFile).isInBuildDirectory()
select androidAppElem.getAttribute("allowBackup"), "The 'android:allowBackup' attribute is enabled."
select androidAppElem, "The 'android:allowBackup' attribute is enabled."

7
java/ql/src/Security/CWE/CWE-312/AllowBackupEmpty.xml Normal file
View File

@@ -0,0 +1,7 @@
<manifest ... >
<!-- BAD: no 'android:allowBackup' set, defaults to 'true' -->
<application>
<activity ... >
</activity>
</application>
</manifest>