Revert "Swift: print a helpful message on macOS ARM"

This commit is contained in:
Paolo Tranquilli
2022-09-14 10:34:46 +02:00
committed by GitHub
parent 6074f22d3f
commit dad0e4decc
2 changed files with 17 additions and 10 deletions

View File

@@ -5,7 +5,11 @@ def _wrap_cc(rule, kwargs):
_add_args(kwargs, "copts", [ _add_args(kwargs, "copts", [
# Required by LLVM/Swift # Required by LLVM/Swift
"-fno-rtti", "-fno-rtti",
]) ] + select({
# temporary, before we do universal merging and have an arm prebuilt package, we make arm build x86
"@platforms//os:macos": ["-arch=x86_64"],
"//conditions:default": [],
}))
_add_args(kwargs, "features", [ _add_args(kwargs, "features", [
# temporary, before we do universal merging # temporary, before we do universal merging
"-universal_binaries", "-universal_binaries",

View File

@@ -1,18 +1,21 @@
package(default_visibility = ["//swift:__subpackages__"]) package(default_visibility = ["//swift:__subpackages__"])
#TODO we will be introducing universal binaries at a later stage, when we have both architectures prebuilt for macOS #TODO we will be introducing universal binaries at a later stage, when we have both architectures prebuilt for macOS
# for the moment, we require --cpu=darwin_x86_64 on an ARM macOS # for the moment, we make arm build an x86_64 binary
_arch_override = {
"darwin_arm64": "darwin_x86_64",
}
[ [
alias( alias(
name = name, name = name,
actual = select( actual = select({
{ "@bazel_tools//src/conditions:%s" % arch: "@swift_prebuilt_%s//:%s" % (
"@bazel_tools//src/conditions:%s" % arch: "@swift_prebuilt_%s//:%s" % (arch, name) _arch_override.get(arch, arch),
for arch in ("linux", "darwin_x86_64") name,
}, )
no_match_error = "Unsupported platform. Support for the ARM macOS platform is still a todo, " + for arch in ("linux", "darwin_x86_64", "darwin_arm64")
"please pass --cpu=darwin_x86_64 for the time being", }),
),
) )
for name in ("swift-llvm-support", "swift-test-sdk") for name in ("swift-llvm-support", "swift-test-sdk")
] ]