From dab45c527edcc2bed5246a7ac876be4512de233c Mon Sep 17 00:00:00 2001 From: Jonas Jensen Date: Wed, 8 Aug 2018 10:05:57 +0200 Subject: [PATCH] C++: cpp/incomplete-parity-check: medium precision As reported in CPP-236, this query has false positives on signed integers that cannot be negative. It could possibly be improved with a local range analysis, but the query would most likely still have so many false positives that we would have to lower its precision. Under our current policy, this change will make the query hidden by default on LGTM. --- cpp/ql/src/Likely Bugs/Arithmetic/BadCheckOdd.ql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/ql/src/Likely Bugs/Arithmetic/BadCheckOdd.ql b/cpp/ql/src/Likely Bugs/Arithmetic/BadCheckOdd.ql index 398e12ec9be..469397d485b 100644 --- a/cpp/ql/src/Likely Bugs/Arithmetic/BadCheckOdd.ql +++ b/cpp/ql/src/Likely Bugs/Arithmetic/BadCheckOdd.ql @@ -4,7 +4,7 @@ * negative numbers. * @kind problem * @problem.severity warning - * @precision high + * @precision medium * @id cpp/incomplete-parity-check * @tags reliability * correctness