diff --git a/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql b/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql index 566a513bca0..4dd91b143dc 100644 --- a/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql +++ b/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql @@ -76,9 +76,8 @@ class CandidateStringLiteral extends StringLiteral { * ``` */ predicate hasObjectProvidingTemplateVariables(CandidateStringLiteral lit) { - exists(DataFlow::CallNode call, DataFlow::ObjectLiteralNode obj, DataFlow::Node stringArg | - stringArg = [StringConcatenation::getRoot(lit.flow()), lit.flow()] and - stringArg = call.getAnArgument() and + exists(DataFlow::CallNode call, DataFlow::ObjectLiteralNode obj | + call.getAnArgument() = [lit.flow(), StringConcatenation::getRoot(lit.flow())] and obj.flowsTo(call.getAnArgument()) and forex(string name | name = lit.getAReferencedVariable() | exists(obj.getAPropertyWrite(name))) )