hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: address review comments

Browse Source
This commit is contained in:
Asger F
2018-10-11 12:45:45 +01:00
parent 9b10254cd4
commit da3e960e39
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
View File

@@ -311,12 +311,17 @@ abstract class BarrierGuardNode extends DataFlow::Node {
abstract predicate blocks(boolean outcome, Expr e);
/**
* Holds if this barrier guard blocks all labels.
* Holds if this barrier guard should block all labels.
*
* To block specific labels only, subclasses should override this with `none()` and
* also override `blocksSpecificLabel`.
*/
predicate blocksAllLabels() { any() }
/**
* Holds if this barrier guard only blocks specific labels, and `label` is one of them.
*
* Subclasses that override this predicate should also override `blocksAllLabels`.
*/
predicate blocksSpecificLabel(FlowLabel label) { none() }
}

6
javascript/ql/src/semmle/javascript/security/TaintedObject.qll
View File

@@ -22,11 +22,11 @@ module TaintedObject {
}
/**
* Gets the flow label representing a deeply tainted objects.
* Gets the flow label representing a deeply tainted object.
*
* A "tainted object" is an array or object whose values are all assumed to be tainted as well.
* A "tainted object" is an array or object whose properties values are all assumed to be tainted as well.
*
* Note that the presence of the `object-taint` label generally implies the presence of the `taint` label as well.
* Note that the presence of the this label generally implies the presence of the `taint` label as well.
*/
FlowLabel label() { result instanceof TaintedObjectLabel }