hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 19:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix minor quality issues in comment and change note

Browse Source
This commit is contained in:
Tamas Vajk
2021-08-19 09:30:23 +02:00
parent 2708326624
commit d97525e21e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
csharp/change-notes/2021-08-05-insecure-randomness.md
View File

@@ -1,2 +1,2 @@
lgtm,codescanning lgtm,codescanning
* Adding `Membership.GeneratePassword()` as a bad source of random data. * Membership.GeneratePassword()` has been added as a bad source of random data.

2
csharp/ql/src/Security Features/InsecureRandomness.cs
View File

@@ -15,7 +15,7 @@ string GeneratePassword()
password = "mypassword" + BitConverter.ToInt32(randomBytes); password = "mypassword" + BitConverter.ToInt32(randomBytes);
} }
// BAD: Membership.GeneratePassword is generates a password with a bias // BAD: Membership.GeneratePassword generates a password with a bias
password = Membership.GeneratePassword(12, 3); password = Membership.GeneratePassword(12, 3);
return password; return password;