hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9150 from tamasvajk/kotlin-MissingInstanceofInEquals

Browse Source 
Kotlin: Add more type check casts to MissingInstanceofInEquals query
This commit is contained in:
Tamás Vajk
2022-05-17 08:43:06 +02:00
committed by GitHub
parent c518150b49 7d5844a9a4
commit d8c22901c9
4 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
View File

@@ -26,6 +26,10 @@ class CheckedCast extends CastExpr {
predicate hasTypeTest(Variable v) {
any(InstanceOfExpr ioe).getExpr() = v.getAnAccess()
or
any(NotInstanceOfExpr nioe).getExpr() = v.getAnAccess()
or
any(SafeCastExpr sce).getExpr() = v.getAnAccess()
or
exists(MethodAccess ma |
ma.getMethod().getName() = "getClass" and
ma.getQualifier() = v.getAnAccess()

0
java/ql/test/kotlin/query-tests/MissingInstanceofInEquals/MissingInstanceofInEquals.expected Normal file
View File

1
java/ql/test/kotlin/query-tests/MissingInstanceofInEquals/MissingInstanceofInEquals.qlref Normal file
View File

@@ -0,0 +1 @@
Likely Bugs/Comparison/MissingInstanceofInEquals.ql

7
java/ql/test/kotlin/query-tests/MissingInstanceofInEquals/Test.kt Normal file
View File

@@ -0,0 +1,7 @@
data class D(val x: Int) {}
data class E(val x: Int) {
override fun equals(other: Any?): Boolean {
return (other as? E)?.x == this.x
}
}