hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Small improvement to go/unhandled-writable-file-close

Browse Source
This commit is contained in:
Owen Mansel-Chan
2025-10-02 15:15:51 +01:00
parent 7fdda87b06
commit d8891e34d1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql
View File

@@ -70,8 +70,8 @@ predicate unhandledCall(DataFlow::CallNode call) {
*/ */
predicate isWritableFileHandle(DataFlow::Node source, DataFlow::CallNode call) { predicate isWritableFileHandle(DataFlow::Node source, DataFlow::CallNode call) {
exists(OpenFileFun f, DataFlow::Node flags, QualifiedName flag | exists(OpenFileFun f, DataFlow::Node flags, QualifiedName flag |
// check that the source is a result of the call // check that the source is the first result of the call
source = call.getAResult() and source = call.getResult(0) and
// find a call to the os.OpenFile function // find a call to the os.OpenFile function
f.getACall() = call and f.getACall() = call and
// get the flags expression used for opening the file // get the flags expression used for opening the file