hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Address review comments

Browse Source
This commit is contained in:
Asger F
2019-08-06 17:03:01 +01:00
parent 5e87d5c751
commit d83f152f39
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javascript/ql/src/semmle/javascript/StringOps.qll
View File

@@ -449,7 +449,7 @@ module StringOps {
}
/**
* A data flow node performs a string concatenation or occurs as an operand
* A data flow node that performs a string concatenation or occurs as an operand
* in a string concatenation.
*
* For example, the expression `x + y + z` contains the following concatenation
@@ -570,7 +570,7 @@ module StringOps {
/**
* Gets the last leaf in this concatenation tree.
*
* For example, `x` is the first leaf in `x + y + z`.
* For example, `z` is the last leaf in `x + y + z`.
*/
pragma[inline]
ConcatenationLeaf getLastLeaf() {
@@ -580,7 +580,7 @@ module StringOps {
/**
* Gets the first leaf in this concatenation tree.
*
* For example, `z` is the last leaf in `x + y + z`.
* For example, `x` is the first leaf in `x + y + z`.
*/
pragma[inline]
ConcatenationLeaf getFirstLeaf() {
@@ -726,7 +726,7 @@ module StringOps {
}
/**
* The root node in a concatenation of one or more strings contain HTML fragments.
* The root node in a concatenation of one or more strings containing HTML fragments.
*/
class HtmlConcatenationRoot extends ConcatenationRoot {
pragma[noinline]

2
javascript/ql/src/semmle/javascript/heuristics/SyntacticHeuristics.qll
View File

@@ -66,7 +66,7 @@ predicate isArgTo(DataFlow::Node arg, string regexp) {
}
/**
* Holds if `n` is concatenation containing something with a name that matches `regexp`.
* Holds if `n` is a concatenation containing something with a name that matches `regexp`.
*/
bindingset[regexp]
predicate isConcatenatedWith(StringOps::Concatenation n, string regexp) {