hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 09:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Address review comments about the comments

Browse Source
This commit is contained in:
Jonas Jensen
2019-05-15 14:55:26 +02:00
parent b52015a584
commit d820fc9cd2
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/semmle/code/cpp/Declaration.qll
View File

@@ -93,7 +93,7 @@ abstract class Declaration extends Locatable, @declaration {
* component of `namespaceQualifier`, no declaring type, and a base name of
* `baseName`.
*
* See the 3-argument `hasQualifiedName` for more examples.
* See the 3-argument `hasQualifiedName` for examples.
*/
predicate hasQualifiedName(string namespaceQualifier, string baseName) {
this.hasQualifiedName(namespaceQualifier, "", baseName)

5
cpp/ql/src/semmle/code/cpp/internal/QualifiedName.qll
View File

@@ -230,11 +230,14 @@ class MemberVariable extends Variable, @membervariable {
override string getName() { membervariables(this, _, result) }
}
// Unlike the usual `EnumConstant`, this one doesn't have a
// `getDeclaringType()`. This simplifies the recursive computation of type
// qualifier names since it can assume that any declaration with a
// `getDeclaringType()` should use that type in its type qualifier name.
class EnumConstant extends Declaration, @enumconstant {
override string getName() { enumconstants(this, _, _, _, result, _) }
UserType getDeclaringEnum() { enumconstants(this, result, _, _, _, _) }
// Unlike the usual `EnumConstant`, this one doesn't have a `getDeclaringType()`.
}
class Function extends Declaration, @function {