hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: refactor DefaultUrlRequest: extract the request library

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-09-03 12:58:07 +02:00
parent 80b81b07c5
commit d7a81ef8ef
1 changed files with 34 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
javascript/ql/src/semmle/javascript/frameworks/UrlRequests.qll
View File

@@ -62,23 +62,6 @@ private class DefaultUrlRequest extends CustomUrlRequest {
DefaultUrlRequest() {
exists (string moduleName, DataFlow::SourceNode callee |
this = callee.getACall() |
(
(
moduleName = "request" or
moduleName = "request-promise" or
moduleName = "request-promise-any" or
moduleName = "request-promise-native"
) and
(
callee = DataFlow::moduleImport(moduleName) or
callee = DataFlow::moduleMember(moduleName, httpMethodName())
) and
(
url = getArgument(0) or
url = getOptionArgument(0, urlPropertyName())
)
)
or
(
moduleName = "superagent" and
callee = DataFlow::moduleMember(moduleName, httpMethodName()) and
@@ -137,4 +120,38 @@ private class DefaultUrlRequest extends CustomUrlRequest {
result = url
}
}
/**
* A model of a URL request in the `request` library.
*/
private class RequestUrlRequest extends CustomUrlRequest {
DataFlow::Node url;
RequestUrlRequest() {
exists (string moduleName, DataFlow::SourceNode callee |
this = callee.getACall() |
(
moduleName = "request" or
moduleName = "request-promise" or
moduleName = "request-promise-any" or
moduleName = "request-promise-native"
) and
(
callee = DataFlow::moduleImport(moduleName) or
callee = DataFlow::moduleMember(moduleName, httpMethodName())
) and
(
url = getArgument(0) or
url = getOptionArgument(0, urlPropertyName())
)
)
}
override DataFlow::Node getUrl() {
result = url
}
}