hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: Adress comments form code review.

Browse Source
This commit is contained in:
Alex Eyers-Taylor
2025-09-11 17:14:08 +01:00
parent dcc5572767
commit d5ee91b1e8
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/lib/semmle/code/java/dataflow/SSA.qll
View File

@@ -253,11 +253,11 @@ class SsaImplicitUpdate extends SsaUpdate {
or
if this.hasImplicitQualifierUpdate()
then
if isNonNonLocal(this)
if isNonLocal(this)
then result = "nonlocal + nonlocal qualifier"
else result = "nonlocal qualifier"
else (
isNonNonLocal(this) and result = "nonlocal"
isNonLocal(this) and result = "nonlocal"
)
}
@@ -289,9 +289,9 @@ class SsaImplicitUpdate extends SsaUpdate {
}
overlay[global]
private predicate isNonNonLocalImpl(SsaImplicitUpdate su) { exists(su.getANonLocalUpdate()) }
private predicate isNonLocalImpl(SsaImplicitUpdate su) { exists(su.getANonLocalUpdate()) }
private predicate isNonNonLocal(SsaImplicitUpdate su) = forceLocal(isNonNonLocalImpl/1)(su)
private predicate isNonLocal(SsaImplicitUpdate su) = forceLocal(isNonLocalImpl/1)(su)
/**
* An SSA variable that represents an uncertain implicit update of the value.

1
java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll
View File

@@ -555,7 +555,6 @@ private module Cached {
Impl::phiHasInputFromBlock(phi, inp, bb)
}
overlay[global]
cached
module DataFlowIntegration {
import DataFlowIntegrationImpl