hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-04 21:25:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Address review comments.

Browse Source
This commit is contained in:
Geoffrey White
2022-05-03 14:08:19 +01:00
parent 9faa825304
commit d5be11bf14
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/src/Security/CWE/CWE-611/XXE.ql
View File

@@ -196,9 +196,9 @@ class Libxml2ParseCall extends FunctionCall {
Libxml2ParseCall() {
exists(string fname | this.getTarget().getName() = fname |
fname = ["xmlCtxtUseOptions"] and optionsArg = 1
fname = "xmlCtxtUseOptions" and optionsArg = 1
or
fname = ["xmlReadFile"] and optionsArg = 2
fname = "xmlReadFile" and optionsArg = 2
or
fname = ["xmlCtxtReadFile", "xmlParseInNodeContext", "xmlReadDoc", "xmlReadFd"] and
optionsArg = 3
@@ -207,7 +207,7 @@ class Libxml2ParseCall extends FunctionCall {
or
fname = ["xmlCtxtReadMemory", "xmlReadIO"] and optionsArg = 5
or
fname = ["xmlCtxtReadIO"] and optionsArg = 6
fname = "xmlCtxtReadIO" and optionsArg = 6
)
}
@@ -221,7 +221,7 @@ class Libxml2ParseCall extends FunctionCall {
* An `xmlParserOption` for `libxml2` that is considered unsafe.
*/
class Libxml2BadOption extends EnumConstant {
Libxml2BadOption() { this.getName().matches(["XML_PARSE_NOENT", "XML_PARSE_DTDLOAD"]) }
Libxml2BadOption() { this.getName() = ["XML_PARSE_NOENT", "XML_PARSE_DTDLOAD"] }
}
/**