hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Improve the example for cpp/return-stack-allocated-memory.

Browse Source
This commit is contained in:
Geoffrey White
2024-07-08 10:59:09 +01:00
parent 3c70583aa2
commit d52210d565
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/src/Likely Bugs/Memory Management/ReturnStackAllocatedMemory.cpp
View File

@@ -1,7 +1,5 @@
Record* fixRecord(Record* r) {
Record myRecord = *r;
delete r;
Record *mkRecord(int value) {
Record myRecord(value);
myRecord.fix();
return &myRecord; //returns reference to myRecord, which is a stack-allocated object
}
return &myRecord; // BAD: return a pointer to `myRecord`, which is a stack-allocated object
}