hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Minor efficiency improvements and comments.

Browse Source
This commit is contained in:
Benjamin Rodes
2024-02-08 10:11:50 -05:00
parent 915aa94b13
commit d4bc2ceb37
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
View File

@@ -21,15 +21,13 @@ import semmle.code.cpp.security.FlowSources
import semmle.code.cpp.ir.dataflow.internal.ModelUtil
import semmle.code.cpp.models.interfaces.DataFlow
import semmle.code.cpp.models.interfaces.Taint
import semmle.code.cpp.ir.implementation.raw.Instruction
import semmle.code.cpp.ir.IR
class UncalledFunction extends Function {
UncalledFunction() {
not exists(Call c | c.getTarget() = this) and
// TODO: Need rationale here, added based on suggestion
//but unclear of the scenario being avoided
not this.(MemberFunction).overrides(_) and
// Ignore functions that appear to be function pointers
// function pointers may be seen as uncalled statically
not exists(FunctionAccess fa | fa.getTarget() = this)
}
}
@@ -39,7 +37,6 @@ class UncalledFunction extends Function {
* Grabs the base type of the underlying type of `t` if `t` is a pointer and checks `isConst()` else
* checks on the underlying type of `t` alone.
*/
bindingset[t]
predicate hasConstSpecifier(Type t) {
if t.getUnderlyingType() instanceof PointerType
then t.getUnderlyingType().(PointerType).getBaseType().isConst()