hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 12:46:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: Use SendCallback/ReceiveCallback in getAck

Browse Source
This commit is contained in:
Asger Feldthaus
2020-04-20 15:12:04 +01:00
parent 679259944f
commit d4978905f8
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
javascript/ql/src/semmle/javascript/frameworks/SocketIO.qll
View File

@@ -283,8 +283,8 @@ module SocketIO {
SendNode getASender() { result.getAReceiver() = this }
/** Gets the acknowledgment callback, if any. */
DataFlow::SourceNode getAck() {
result.(ReceiveCallback).getReceiveNode() = this
ReceiveCallback getAck() {
result.getReceiveNode() = this
}
/** DEPRECATED. Use `getChannel()` instead. */
@@ -374,10 +374,8 @@ module SocketIO {
}
/** Gets the acknowledgment callback, if any. */
DataFlow::FunctionNode getAck() {
// acknowledgments are only available when sending through a socket
exists(getSocket()) and
result = getLastArgument().getALocalSource()
SendCallback getAck() {
result.getSendNode() =this
}
/** DEPRECATED. Use `getChannel()` instead. */
@@ -576,8 +574,7 @@ module SocketIOClient {
/** Gets the acknowledgment callback, if any. */
DataFlow::SourceNode getAck() {
result = getListener().getLastParameter() and
exists(result.getAnInvocation())
result.(ReceiveCallback).getReceiveNode() = this
}
/** Gets a server-side node that may be sending the data received here. */
@@ -664,9 +661,7 @@ module SocketIOClient {
/** Gets the acknowledgment callback, if any. */
DataFlow::FunctionNode getAck() {
// acknowledgments are only available when sending through a socket
exists(getSocket()) and
result = getLastArgument().getALocalSource()
result.(SendCallback).getSendNode() = this
}
/** DEPRECATED. Use `getChannel()` instead. */