hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 00:35:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: more name-based heuristic tests to test regex

Browse Source
This commit is contained in:
Jami Cogswell
2024-12-19 18:59:25 -05:00
parent 0ab37684e1
commit d4114f66c2
1 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
java/ql/test/query-tests/security/CWE-352/CsrfUnprotectedRequestTypeTest.java
View File

@@ -371,13 +371,33 @@ public class CsrfUnprotectedRequestTypeTest {
myBatisService.bad10(user);
}
// Test name-based heuristic
// Test name-based heuristic for method names that imply a state-change
@GetMapping(value = "transfer")
public String transfer(@RequestParam String user) { return "transfer"; } // $ hasCsrfUnprotectedRequestType
// BAD: method name implies a state-change
@GetMapping(value = "delete")
public String delete(@RequestParam String user) { // $ hasCsrfUnprotectedRequestType
return "delete";
}
@GetMapping(value = "transfer")
public String transferData(@RequestParam String user) { return "transfer"; } // $ hasCsrfUnprotectedRequestType
@GetMapping(value = "transfer")
public String doTransfer(@RequestParam String user) { return "transfer"; } // $ hasCsrfUnprotectedRequestType
@GetMapping(value = "transfer")
public String doTransferAllData(@RequestParam String user) { return "transfer"; } // $ hasCsrfUnprotectedRequestType
@GetMapping(value = "transfer")
public String doDataTransfer(@RequestParam String user) { return "transfer"; } // $ hasCsrfUnprotectedRequestType
@GetMapping(value = "transfer")
public String transfered(@RequestParam String user) { return "transfer"; } // OK: we look for 'transfer' only
@GetMapping(value = "transfer")
public String dotransfer(@RequestParam String user) { return "transfer"; } // OK: we look for 'transfer' within camelCase only
@GetMapping(value = "transfer")
public String doTransferdata(@RequestParam String user) { return "transfer"; } // OK: we look for 'transfer' within camelCase only
@GetMapping(value = "transfer")
public String getTransfer(@RequestParam String user) { return "transfer"; } // OK: starts with 'get'
// Test Stapler web methods with name-based heuristic