hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 16:25:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove Url#parse as a source

Browse Source
This commit is contained in:
Ed Minnix
2023-02-13 13:30:21 -05:00
parent 5f4e8e3e6a
commit d3d712fbff
3 changed files with 38 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/test/query-tests/security/CWE-094/APKInstallation.expected
View File

@@ -1,18 +1,16 @@
edges
nodes
| APKInstallation.java:14:31:14:58 | fromFile(...) | semmle.label | fromFile(...) |
| APKInstallation.java:21:31:21:44 | parse(...) | semmle.label | parse(...) |
| APKInstallation.java:29:24:29:38 | parse(...) | semmle.label | parse(...) |
| APKInstallation.java:36:24:36:51 | fromFile(...) | semmle.label | fromFile(...) |
| APKInstallation.java:43:31:43:48 | fromFile(...) | semmle.label | fromFile(...) |
| APKInstallation.java:50:24:50:41 | fromFile(...) | semmle.label | fromFile(...) |
| APKInstallation.java:57:24:57:41 | fromFile(...) | semmle.label | fromFile(...) |
| APKInstallation.java:70:24:70:41 | fromFile(...) | semmle.label | fromFile(...) |
subpaths
#select
| APKInstallation.java:14:31:14:58 | fromFile(...) | APKInstallation.java:14:31:14:58 | fromFile(...) | APKInstallation.java:14:31:14:58 | fromFile(...) | Arbitrary Android APK installation. |
| APKInstallation.java:21:31:21:44 | parse(...) | APKInstallation.java:21:31:21:44 | parse(...) | APKInstallation.java:21:31:21:44 | parse(...) | Arbitrary Android APK installation. |
| APKInstallation.java:29:24:29:38 | parse(...) | APKInstallation.java:29:24:29:38 | parse(...) | APKInstallation.java:29:24:29:38 | parse(...) | Arbitrary Android APK installation. |
| APKInstallation.java:36:24:36:51 | fromFile(...) | APKInstallation.java:36:24:36:51 | fromFile(...) | APKInstallation.java:36:24:36:51 | fromFile(...) | Arbitrary Android APK installation. |
| APKInstallation.java:43:31:43:48 | fromFile(...) | APKInstallation.java:43:31:43:48 | fromFile(...) | APKInstallation.java:43:31:43:48 | fromFile(...) | Arbitrary Android APK installation. |
| APKInstallation.java:50:24:50:41 | fromFile(...) | APKInstallation.java:50:24:50:41 | fromFile(...) | APKInstallation.java:50:24:50:41 | fromFile(...) | Arbitrary Android APK installation. |
| APKInstallation.java:57:24:57:41 | fromFile(...) | APKInstallation.java:57:24:57:41 | fromFile(...) | APKInstallation.java:57:24:57:41 | fromFile(...) | Arbitrary Android APK installation. |
| APKInstallation.java:70:24:70:41 | fromFile(...) | APKInstallation.java:70:24:70:41 | fromFile(...) | APKInstallation.java:70:24:70:41 | fromFile(...) | Arbitrary Android APK installation. |

15
java/ql/test/query-tests/security/CWE-094/APKInstallation.java
View File

@@ -57,4 +57,19 @@ public class APKInstallation extends Activity {
intent.setData(Uri.fromFile(file));
startActivity(intent);
}
public void openWebsite() {
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setData(Uri.parse("http://www.example.com"));
startActivity(intent);
}
public void otherIntent(File file) {
Intent intent = new Intent(this, OtherActivity.class);
intent.setAction(Intent.ACTION_VIEW);
intent.setData(Uri.fromFile(file));
}
}
class OtherActivity extends Activity {
}