hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Use the index to to get the 'most converted' and 'least converted' instruction in a bunch of places.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-09-01 13:03:29 +01:00
parent 4dfaf9225c
commit d2bb73ba1f
12 changed files with 187 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/test/library-tests/dataflow/fields/dataflow-ir-consistency.expected
View File

@@ -57,16 +57,6 @@ uniqueNodeToString
| aliasing.cpp:132:9:132:14 | & ... | Node should have one toString but has 3. |
| aliasing.cpp:132:9:132:14 | * ... | Node should have one toString but has 3. |
| aliasing.cpp:132:9:132:14 | xs | Node should have one toString but has 3. |
| aliasing.cpp:132:10:132:14 | & ... | Node should have one toString but has 3. |
| aliasing.cpp:132:10:132:14 | & ... indirection | Node should have one toString but has 3. |
| aliasing.cpp:132:10:132:14 | * ... | Node should have one toString but has 3. |
| aliasing.cpp:132:10:132:14 | * ... indirection | Node should have one toString but has 3. |
| aliasing.cpp:132:10:132:14 | xs | Node should have one toString but has 3. |
| aliasing.cpp:132:10:132:14 | xs indirection | Node should have one toString but has 3. |
| aliasing.cpp:132:11:132:14 | * ... | Node should have one toString but has 2. |
| aliasing.cpp:132:11:132:14 | * ... indirection | Node should have one toString but has 2. |
| aliasing.cpp:132:11:132:14 | xs | Node should have one toString but has 2. |
| aliasing.cpp:132:11:132:14 | xs indirection | Node should have one toString but has 2. |
| aliasing.cpp:136:15:136:17 | + ... | Node should have one toString but has 2. |
| aliasing.cpp:136:15:136:17 | + ... indirection | Node should have one toString but has 2. |
| aliasing.cpp:136:15:136:17 | xs | Node should have one toString but has 2. |

20
cpp/ql/test/library-tests/dataflow/fields/ir-path-flow.expected
View File

@@ -13,6 +13,8 @@ edges
| A.cpp:41:5:41:6 | insert output argument | A.cpp:43:10:43:12 | & ... indirection |
| A.cpp:41:5:41:6 | insert output argument | A.cpp:43:10:43:12 | ct indirection |
| A.cpp:41:15:41:21 | new | A.cpp:41:5:41:6 | insert output argument |
| A.cpp:41:15:41:21 | new | A.cpp:41:5:41:6 | insert output argument |
| A.cpp:41:15:41:21 | new | A.cpp:41:15:41:21 | new |
| A.cpp:47:12:47:18 | new | A.cpp:48:20:48:20 | c |
| A.cpp:48:12:48:18 | call to make indirection [c] | A.cpp:49:10:49:10 | b indirection [c] |
| A.cpp:48:20:48:20 | c | A.cpp:29:23:29:23 | c |
@@ -21,6 +23,7 @@ edges
| A.cpp:55:5:55:5 | set output argument [c] | A.cpp:56:10:56:10 | b indirection [c] |
| A.cpp:55:12:55:19 | new | A.cpp:27:17:27:17 | c |
| A.cpp:55:12:55:19 | new | A.cpp:55:5:55:5 | set output argument [c] |
| A.cpp:55:12:55:19 | new | A.cpp:55:12:55:19 | new |
| A.cpp:56:10:56:10 | b indirection [c] | A.cpp:28:8:28:10 | this indirection [c] |
| A.cpp:56:10:56:10 | b indirection [c] | A.cpp:56:10:56:17 | call to get |
| A.cpp:57:11:57:24 | call to B [c] | A.cpp:57:11:57:24 | new indirection [c] |
@@ -31,10 +34,12 @@ edges
| A.cpp:57:17:57:23 | new | A.cpp:57:17:57:23 | new |
| A.cpp:64:10:64:15 | call to setOnB indirection [c] | A.cpp:66:10:66:11 | b2 indirection [c] |
| A.cpp:64:21:64:28 | new | A.cpp:64:10:64:15 | call to setOnB indirection [c] |
| A.cpp:64:21:64:28 | new | A.cpp:64:21:64:28 | new |
| A.cpp:64:21:64:28 | new | A.cpp:85:26:85:26 | c |
| A.cpp:66:10:66:11 | b2 indirection [c] | A.cpp:66:10:66:14 | c |
| A.cpp:73:10:73:19 | call to setOnBWrap indirection [c] | A.cpp:75:10:75:11 | b2 indirection [c] |
| A.cpp:73:25:73:32 | new | A.cpp:73:10:73:19 | call to setOnBWrap indirection [c] |
| A.cpp:73:25:73:32 | new | A.cpp:73:25:73:32 | new |
| A.cpp:73:25:73:32 | new | A.cpp:78:27:78:27 | c |
| A.cpp:75:10:75:11 | b2 indirection [c] | A.cpp:75:10:75:14 | c |
| A.cpp:78:27:78:27 | c | A.cpp:81:21:81:21 | c |
@@ -853,6 +858,7 @@ nodes
| A.cpp:31:20:31:20 | c | semmle.label | c |
| A.cpp:41:5:41:6 | insert output argument | semmle.label | insert output argument |
| A.cpp:41:15:41:21 | new | semmle.label | new |
| A.cpp:41:15:41:21 | new | semmle.label | new |
| A.cpp:43:10:43:12 | & ... indirection | semmle.label | & ... indirection |
| A.cpp:43:10:43:12 | & ... indirection | semmle.label | ct indirection |
| A.cpp:43:10:43:12 | ct indirection | semmle.label | & ... indirection |
@@ -864,6 +870,7 @@ nodes
| A.cpp:49:10:49:13 | c | semmle.label | c |
| A.cpp:55:5:55:5 | set output argument [c] | semmle.label | set output argument [c] |
| A.cpp:55:12:55:19 | new | semmle.label | new |
| A.cpp:55:12:55:19 | new | semmle.label | new |
| A.cpp:56:10:56:10 | b indirection [c] | semmle.label | b indirection [c] |
| A.cpp:56:10:56:17 | call to get | semmle.label | call to get |
| A.cpp:57:10:57:32 | call to get | semmle.label | call to get |
@@ -873,10 +880,12 @@ nodes
| A.cpp:57:17:57:23 | new | semmle.label | new |
| A.cpp:64:10:64:15 | call to setOnB indirection [c] | semmle.label | call to setOnB indirection [c] |
| A.cpp:64:21:64:28 | new | semmle.label | new |
| A.cpp:64:21:64:28 | new | semmle.label | new |
| A.cpp:66:10:66:11 | b2 indirection [c] | semmle.label | b2 indirection [c] |
| A.cpp:66:10:66:14 | c | semmle.label | c |
| A.cpp:73:10:73:19 | call to setOnBWrap indirection [c] | semmle.label | call to setOnBWrap indirection [c] |
| A.cpp:73:25:73:32 | new | semmle.label | new |
| A.cpp:73:25:73:32 | new | semmle.label | new |
| A.cpp:75:10:75:11 | b2 indirection [c] | semmle.label | b2 indirection [c] |
| A.cpp:75:10:75:14 | c | semmle.label | c |
| A.cpp:78:6:78:15 | setOnBWrap indirection [c] | semmle.label | setOnBWrap indirection [c] |
@@ -1788,17 +1797,28 @@ subpaths
| simple.cpp:84:14:84:20 | this indirection [f2, f1] | simple.cpp:78:9:78:15 | this indirection [f2, f1] | simple.cpp:78:9:78:15 | getf2f1 indirection | simple.cpp:84:14:84:20 | call to getf2f1 |
#select
| A.cpp:43:10:43:12 | & ... indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | & ... indirection | & ... indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | & ... indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | & ... indirection | & ... indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | & ... indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | & ... indirection | ct indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | & ... indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | & ... indirection | ct indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | & ... indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | ct indirection | & ... indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | & ... indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | ct indirection | & ... indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | & ... indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | ct indirection | ct indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | & ... indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | ct indirection | ct indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | ct indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | & ... indirection | & ... indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | ct indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | & ... indirection | & ... indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | ct indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | & ... indirection | ct indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | ct indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | & ... indirection | ct indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | ct indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | ct indirection | & ... indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | ct indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | ct indirection | & ... indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | ct indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | ct indirection | ct indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:43:10:43:12 | ct indirection | A.cpp:41:15:41:21 | new | A.cpp:43:10:43:12 | ct indirection | ct indirection flows from $@ | A.cpp:41:15:41:21 | new | new |
| A.cpp:49:10:49:13 | c | A.cpp:47:12:47:18 | new | A.cpp:49:10:49:13 | c | c flows from $@ | A.cpp:47:12:47:18 | new | new |
| A.cpp:56:10:56:17 | call to get | A.cpp:55:12:55:19 | new | A.cpp:56:10:56:17 | call to get | call to get flows from $@ | A.cpp:55:12:55:19 | new | new |
| A.cpp:56:10:56:17 | call to get | A.cpp:55:12:55:19 | new | A.cpp:56:10:56:17 | call to get | call to get flows from $@ | A.cpp:55:12:55:19 | new | new |
| A.cpp:57:10:57:32 | call to get | A.cpp:57:17:57:23 | new | A.cpp:57:10:57:32 | call to get | call to get flows from $@ | A.cpp:57:17:57:23 | new | new |
| A.cpp:66:10:66:14 | c | A.cpp:64:21:64:28 | new | A.cpp:66:10:66:14 | c | c flows from $@ | A.cpp:64:21:64:28 | new | new |
| A.cpp:66:10:66:14 | c | A.cpp:64:21:64:28 | new | A.cpp:66:10:66:14 | c | c flows from $@ | A.cpp:64:21:64:28 | new | new |
| A.cpp:75:10:75:14 | c | A.cpp:73:25:73:32 | new | A.cpp:75:10:75:14 | c | c flows from $@ | A.cpp:73:25:73:32 | new | new |
| A.cpp:75:10:75:14 | c | A.cpp:73:25:73:32 | new | A.cpp:75:10:75:14 | c | c flows from $@ | A.cpp:73:25:73:32 | new | new |
| A.cpp:107:12:107:16 | a | A.cpp:98:12:98:18 | new | A.cpp:107:12:107:16 | a | a flows from $@ | A.cpp:98:12:98:18 | new | new |
| A.cpp:120:12:120:16 | a | A.cpp:98:12:98:18 | new | A.cpp:120:12:120:16 | a | a flows from $@ | A.cpp:98:12:98:18 | new | new |

46
cpp/ql/test/library-tests/dataflow/taint-tests/taint.expected
View File

@@ -4,8 +4,46 @@ WARNING: Module DataFlow has been deprecated and may be removed in future (taint
WARNING: Module DataFlow has been deprecated and may be removed in future (taint.ql:68,25-33)
WARNING: Module TaintTracking has been deprecated and may be removed in future (taint.ql:73,20-33)
testFailures
| map.cpp:172:20:172:30 | // $ ast,ir | Missing result:ir= |
| map.cpp:174:20:174:30 | // $ ast,ir | Missing result:ir= |
| map.cpp:324:20:324:30 | // $ ast,ir | Missing result:ir= |
| map.cpp:326:20:326:30 | // $ ast,ir | Missing result:ir= |
| map.cpp:168:7:168:27 | ... = ... | Unexpected result: ir=168:7 |
| map.cpp:168:7:168:27 | ... = ... | Unexpected result: ir=168:20 |
| map.cpp:168:7:168:27 | ... = ... indirection | Unexpected result: ir=168:7 |
| map.cpp:168:7:168:27 | ... = ... indirection | Unexpected result: ir=168:20 |
| map.cpp:168:7:168:27 | call to source | Unexpected result: ir=168:7 |
| map.cpp:168:7:168:27 | call to source | Unexpected result: ir=168:20 |
| map.cpp:168:7:168:27 | call to source indirection | Unexpected result: ir=168:7 |
| map.cpp:168:7:168:27 | call to source indirection | Unexpected result: ir=168:20 |
| map.cpp:168:31:168:41 | // $ ast,ir | Missing result:ir= |
| map.cpp:170:7:170:30 | ... = ... | Unexpected result: ir=170:7 |
| map.cpp:170:7:170:30 | ... = ... | Unexpected result: ir=170:23 |
| map.cpp:170:7:170:30 | ... = ... indirection | Unexpected result: ir=170:7 |
| map.cpp:170:7:170:30 | ... = ... indirection | Unexpected result: ir=170:23 |
| map.cpp:170:7:170:30 | call to source | Unexpected result: ir=170:7 |
| map.cpp:170:7:170:30 | call to source | Unexpected result: ir=170:23 |
| map.cpp:170:7:170:30 | call to source indirection | Unexpected result: ir=170:7 |
| map.cpp:170:7:170:30 | call to source indirection | Unexpected result: ir=170:23 |
| map.cpp:170:34:170:44 | // $ ast,ir | Missing result:ir= |
| map.cpp:320:7:320:27 | ... = ... | Unexpected result: ir=320:7 |
| map.cpp:320:7:320:27 | ... = ... | Unexpected result: ir=320:20 |
| map.cpp:320:7:320:27 | ... = ... indirection | Unexpected result: ir=320:7 |
| map.cpp:320:7:320:27 | ... = ... indirection | Unexpected result: ir=320:20 |
| map.cpp:320:7:320:27 | call to source | Unexpected result: ir=320:7 |
| map.cpp:320:7:320:27 | call to source | Unexpected result: ir=320:20 |
| map.cpp:320:7:320:27 | call to source indirection | Unexpected result: ir=320:7 |
| map.cpp:320:7:320:27 | call to source indirection | Unexpected result: ir=320:20 |
| map.cpp:320:31:320:41 | // $ ast,ir | Missing result:ir= |
| map.cpp:322:7:322:30 | ... = ... | Unexpected result: ir=322:7 |
| map.cpp:322:7:322:30 | ... = ... | Unexpected result: ir=322:23 |
| map.cpp:322:7:322:30 | ... = ... indirection | Unexpected result: ir=322:7 |
| map.cpp:322:7:322:30 | ... = ... indirection | Unexpected result: ir=322:23 |
| map.cpp:322:7:322:30 | call to source | Unexpected result: ir=322:7 |
| map.cpp:322:7:322:30 | call to source | Unexpected result: ir=322:23 |
| map.cpp:322:7:322:30 | call to source indirection | Unexpected result: ir=322:7 |
| map.cpp:322:7:322:30 | call to source indirection | Unexpected result: ir=322:23 |
| map.cpp:322:34:322:44 | // $ ast,ir | Missing result:ir= |
| taint.cpp:16:8:16:14 | source1 | Unexpected result: ir=12:13 |
| taint.cpp:16:8:16:14 | source1 | Unexpected result: ir=12:22 |
| taint.cpp:16:18:16:28 | // $ ast,ir | Missing result:ir= |
| taint.cpp:17:8:17:16 | ++ ... | Unexpected result: ir=12:13 |
| taint.cpp:17:8:17:16 | ++ ... | Unexpected result: ir=12:22 |
| taint.cpp:17:20:17:30 | // $ ast,ir | Missing result:ir= |
failures