diff --git a/ql/src/experimental/frameworks/Fiber.json b/ql/src/experimental/frameworks/Fiber.json index 142dcc81264..30549353dc1 100644 --- a/ql/src/experimental/frameworks/Fiber.json +++ b/ql/src/experimental/frameworks/Fiber.json @@ -1,5 +1,6 @@ { "Name": "Fiber", + "Preload": null, "Models": [ { "Name": "TaintTracking", @@ -929,17 +930,15 @@ } }, { - "Kind": "Func", + "Kind": "Struct", "Qualifier": { "Path": "github.com/gofiber/fiber", "Version": "v1.14.6", - "ID": "TypeMethod-Ctx-Protocol", - "Pos": [ - false, - true - ], - "Flows": null, - "Name": "Protocol" + "ID": "Struct-Error", + "TypeName": "Error", + "Fields": { + "Message": null + } } }, { @@ -1019,18 +1018,6 @@ "Value": null } } - }, - { - "Kind": "Struct", - "Qualifier": { - "Path": "github.com/gofiber/fiber", - "Version": "v1.14.6", - "ID": "Struct-Error", - "TypeName": "Error", - "Fields": { - "Message": null - } - } } ] } diff --git a/ql/src/experimental/frameworks/Fiber.qll b/ql/src/experimental/frameworks/Fiber.qll index b657846ba6a..08a0d961d41 100644 --- a/ql/src/experimental/frameworks/Fiber.qll +++ b/ql/src/experimental/frameworks/Fiber.qll @@ -366,10 +366,6 @@ private module Fiber { methodName = "Path" and out.isResult() or - // signature: func (*Ctx).Protocol() string - methodName = "Protocol" and - out.isResult() - or // signature: func (*Ctx).Query(key string, defaultValue ...string) string methodName = "Query" and out.isResult() diff --git a/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go b/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go index 1f8e3b61a36..23f2afe87a2 100644 --- a/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go +++ b/ql/test/experimental/frameworks/Fiber/UntrustedFlowSources.go @@ -89,12 +89,6 @@ func UntrustedFlowSources_GithubComGofiberFiberV1146() { result544 := receiverCtx648.Path("") sink(result544) // $untrustedFlowSource } - // func (*Ctx).Protocol() string - { - var receiverCtx484 fiber.Ctx - result824 := receiverCtx484.Protocol() - sink(result824) // $untrustedFlowSource - } // func (*Ctx).Query(key string, defaultValue ...string) string { var receiverCtx754 fiber.Ctx