hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-16 04:24:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: restrict sink to first arg of two-arg constructor call

Browse Source
This commit is contained in:
Jami Cogswell
2025-02-05 21:19:59 -05:00
parent bd47dcc87d
commit d21c8d789b
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/lib/semmle/code/java/security/PathSanitizer.qll
View File

@@ -366,10 +366,16 @@ private module TaintedArgConfig implements DataFlow::ConfigSig {
src.asExpr().(MethodCall).getMethod().getName() = "source"
}
predicate isSink(DataFlow::Node sink) { exists(Call call | sink.asExpr() = call.getAnArgument()) }
predicate isSink(DataFlow::Node sink) {
sink.asExpr() =
any(ConstructorCall constrCall |
constrCall.getConstructedType() instanceof TypeFile and
constrCall.getNumArgument() = 2
).getArgument(0)
}
}
/** Tracks taint flow to any argument. */
/** Tracks taint flow to the parent argument of a `File` constructor. */
private module TaintedArgFlow = TaintTracking::Global<TaintedArgConfig>;
/** Holds if `g` is a guard that checks for `..` components. */