hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

python: unnecessary abstract class

Browse Source 
It is enough to make the predicates abstract,
so the whole -`Impl`-construction was unnecessary.
This commit is contained in:
Rasmus Lerchedahl Petersen
2022-12-16 12:43:41 +01:00
parent 5094897668
commit d216460032
1 changed files with 5 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
python/ql/lib/semmle/python/Stmts.qll
View File

@@ -146,24 +146,8 @@ class Exec extends Exec_ {
/**
* An exception handler such as an `except` or an `except*` statement
* in a `try` statement.
*
* We do not wish to expose an abstract class that users are not
* meant to extend, so this class is kept private. The user facing
* class is `ExceptionHandler`.
*/
abstract private class ExceptionHandlerImpl extends Stmt {
/** Gets the name of this except group block. */
abstract Expr getName();
/** Gets the type of this except group block. */
abstract Expr getType();
}
/**
* An exception handler such as an `except` or an `except*` statement
* in a `try` statement.
*/
class ExceptionHandler extends Stmt instanceof ExceptionHandlerImpl {
class ExceptionHandler extends Stmt {
ExceptionHandler() {
this instanceof ExceptStmt_
or
@@ -174,14 +158,14 @@ class ExceptionHandler extends Stmt instanceof ExceptionHandlerImpl {
Try getTry() { result.getAHandler() = this }
/** Gets the name of this except group block. */
Expr getName() { result = super.getName() }
abstract Expr getName();
/** Gets the type of this except group block. */
Expr getType() { result = super.getType() }
abstract Expr getType();
}
/** An except group statement (part of a `try` statement), such as `except* IOError as err:` */
class ExceptGroupStmt extends ExceptGroupStmt_, ExceptionHandlerImpl {
class ExceptGroupStmt extends ExceptGroupStmt_, ExceptionHandler {
/* syntax: except Expr [ as Expr ]: */
override Expr getASubExpression() {
result = this.getName()
@@ -203,7 +187,7 @@ class ExceptGroupStmt extends ExceptGroupStmt_, ExceptionHandlerImpl {
}
/** An except statement (part of a `try` statement), such as `except IOError as err:` */
class ExceptStmt extends ExceptStmt_, ExceptionHandlerImpl {
class ExceptStmt extends ExceptStmt_, ExceptionHandler {
/* syntax: except Expr [ as Expr ]: */
override Expr getASubExpression() {
result = this.getName()