hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 11:16:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

(Minor) Update comments to match ExternalFlow docs

Browse Source
This commit is contained in:
Owen Mansel-Chan
2021-05-20 12:17:05 +01:00
parent 1ae9d68409
commit d1fe62d4d5
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/semmle/code/java/frameworks/guava/Base.qll
View File

@@ -7,7 +7,7 @@ private class GuavaBaseCsv extends SummaryModelCsv {
override predicate row(string row) { override predicate row(string row) {
row = row =
[ [
//"package;type;overrides;name;signature;ext;inputspec;outputspec;kind", //`namespace; type; subtypes; name; signature; ext; input; output; kind`
"com.google.common.base;Strings;false;emptyToNull;(String);;Argument[0];ReturnValue;value", "com.google.common.base;Strings;false;emptyToNull;(String);;Argument[0];ReturnValue;value",
"com.google.common.base;Strings;false;nullToEmpty;(String);;Argument[0];ReturnValue;value", "com.google.common.base;Strings;false;nullToEmpty;(String);;Argument[0];ReturnValue;value",
"com.google.common.base;Strings;false;padStart;(String,int,char);;Argument[0];ReturnValue;taint", "com.google.common.base;Strings;false;padStart;(String,int,char);;Argument[0];ReturnValue;taint",

4
java/ql/src/semmle/code/java/frameworks/guava/IO.qll
View File

@@ -7,7 +7,7 @@ private class GuavaIoCsv extends SummaryModelCsv {
override predicate row(string row) { override predicate row(string row) {
row = row =
[ [
//"package;type;overrides;name;signature;ext;inputspec;outputspec;kind", //`namespace; type; subtypes; name; signature; ext; input; output; kind`
"com.google.common.io;BaseEncoding;true;decode;(CharSequence);;Argument[0];ReturnValue;taint", "com.google.common.io;BaseEncoding;true;decode;(CharSequence);;Argument[0];ReturnValue;taint",
"com.google.common.io;BaseEncoding;true;decodingStream;(Reader);;Argument[0];ReturnValue;taint", "com.google.common.io;BaseEncoding;true;decodingStream;(Reader);;Argument[0];ReturnValue;taint",
"com.google.common.io;BaseEncoding;true;decodingSource;(CharSource);;Argument[0];ReturnValue;taint", "com.google.common.io;BaseEncoding;true;decodingSource;(CharSource);;Argument[0];ReturnValue;taint",
@@ -89,7 +89,7 @@ private class GuavaIoSinkCsv extends SinkModelCsv {
override predicate row(string row) { override predicate row(string row) {
row = row =
[ [
//"package;type;overrides;name;signature;ext;inputspec;kind", //`namespace; type; subtypes; name; signature; ext; input; kind`
"com.google.common.io;Resources;false;asByteSource;(URL);;Argument[0];url-open-stream", "com.google.common.io;Resources;false;asByteSource;(URL);;Argument[0];url-open-stream",
"com.google.common.io;Resources;false;asCharSource;(URL,Charset);;Argument[0];url-open-stream", "com.google.common.io;Resources;false;asCharSource;(URL,Charset);;Argument[0];url-open-stream",
"com.google.common.io;Resources;false;copy;(URL,OutputStream);;Argument[0];url-open-stream", "com.google.common.io;Resources;false;copy;(URL,OutputStream);;Argument[0];url-open-stream",

2
java/ql/test/library-tests/dataflow/external-models/sinks.ql
View File

@@ -7,7 +7,7 @@ class SinkModelTest extends SinkModelCsv {
override predicate row(string row) { override predicate row(string row) {
row = row =
[ [
//"package;type;overrides;name;signature;ext;spec;kind", //`namespace; type; subtypes; name; signature; ext; input; kind`
"my.qltest;B;false;sink1;(Object);;Argument[0];qltest", "my.qltest;B;false;sink1;(Object);;Argument[0];qltest",
"my.qltest;B;false;sinkMethod;();;ReturnValue;qltest", "my.qltest;B;false;sinkMethod;();;ReturnValue;qltest",
"my.qltest;B$Tag;false;;;Annotated;ReturnValue;qltest-retval", "my.qltest;B$Tag;false;;;Annotated;ReturnValue;qltest-retval",

2
java/ql/test/library-tests/dataflow/external-models/srcs.ql
View File

@@ -7,7 +7,7 @@ class SourceModelTest extends SourceModelCsv {
override predicate row(string row) { override predicate row(string row) {
row = row =
[ [
//"package;type;overrides;name;signature;ext;spec;kind", //`namespace; type; subtypes; name; signature; ext; output; kind`
"my.qltest;A;false;src1;();;ReturnValue;qltest", "my.qltest;A;false;src1;();;ReturnValue;qltest",
"my.qltest;A;false;src1;(String);;ReturnValue;qltest", "my.qltest;A;false;src1;(String);;ReturnValue;qltest",
"my.qltest;A;false;src1;(java.lang.String);;ReturnValue;qltest-alt", "my.qltest;A;false;src1;(java.lang.String);;ReturnValue;qltest-alt",

2
java/ql/test/library-tests/dataflow/external-models/steps.ql
View File

@@ -8,7 +8,7 @@ class SummaryModelTest extends SummaryModelCsv {
override predicate row(string row) { override predicate row(string row) {
row = row =
[ [
//"package;type;overrides;name;signature;ext;inputspec;outputspec;kind", //`namespace; type; subtypes; name; signature; ext; input; output; kind`
"my.qltest;C;false;stepArgRes;(Object);;Argument[0];ReturnValue;taint", "my.qltest;C;false;stepArgRes;(Object);;Argument[0];ReturnValue;taint",
"my.qltest;C;false;stepArgArg;(Object,Object);;Argument[0];Argument[1];taint", "my.qltest;C;false;stepArgArg;(Object,Object);;Argument[0];Argument[1];taint",
"my.qltest;C;false;stepArgQual;(Object);;Argument[0];Argument[-1];taint", "my.qltest;C;false;stepArgQual;(Object);;Argument[0];Argument[-1];taint",