From d10dbbdd9d1624eb38d9c2d3ba33a8341efdb809 Mon Sep 17 00:00:00 2001 From: Tony Torralba Date: Mon, 26 Jul 2021 16:57:12 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Marcono1234 --- java/change-notes/2021-06-08-spel-injection-query.md | 2 +- .../src/semmle/code/java/frameworks/spring/SpringExpression.qll | 2 +- java/ql/src/semmle/code/java/security/SpelInjectionQuery.qll | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/java/change-notes/2021-06-08-spel-injection-query.md b/java/change-notes/2021-06-08-spel-injection-query.md index 6e93fe66838..1191eac7bd3 100644 --- a/java/change-notes/2021-06-08-spel-injection-query.md +++ b/java/change-notes/2021-06-08-spel-injection-query.md @@ -1,2 +1,2 @@ lgtm,codescanning -* The query "Expression language injection (Spring)" (`java/spel-expression-injection`) has been promoted from experimental to the main query pack. Its results will now appear by default. This query was originally [submitted as an experimental query by @artem-smotrakov](https://github.com/github/codeql/pull/3291) \ No newline at end of file +* The query "Expression language injection (Spring)" (`java/spel-expression-injection`) has been promoted from experimental to the main query pack. Its results will now appear by default. This query was originally [submitted as an experimental query by @artem-smotrakov](https://github.com/github/codeql/pull/3291). diff --git a/java/ql/src/semmle/code/java/frameworks/spring/SpringExpression.qll b/java/ql/src/semmle/code/java/frameworks/spring/SpringExpression.qll index 624ea8292f1..0b79587c551 100644 --- a/java/ql/src/semmle/code/java/frameworks/spring/SpringExpression.qll +++ b/java/ql/src/semmle/code/java/frameworks/spring/SpringExpression.qll @@ -22,7 +22,7 @@ class ExpressionParser extends RefType { } /** - * The class `org.springframework.expression.spel.support."SimpleEvaluationContext$Builder`. + * The class `org.springframework.expression.spel.support.SimpleEvaluationContext$Builder`. */ class SimpleEvaluationContextBuilder extends RefType { SimpleEvaluationContextBuilder() { diff --git a/java/ql/src/semmle/code/java/security/SpelInjectionQuery.qll b/java/ql/src/semmle/code/java/security/SpelInjectionQuery.qll index 65a6d6df071..ffccce1fbfa 100644 --- a/java/ql/src/semmle/code/java/security/SpelInjectionQuery.qll +++ b/java/ql/src/semmle/code/java/security/SpelInjectionQuery.qll @@ -54,7 +54,7 @@ private class SafeEvaluationContextFlowConfig extends DataFlow2::Configuration { } /** - * A `ContextSource` that is safe from SpEL injection + * A `ContextSource` that is safe from SpEL injection. */ private class SafeContextSource extends DataFlow::ExprNode { SafeContextSource() {