hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 22:32:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make the gofmt CI test actaully fatal

Browse Source 
Turns out gofmt doesn't actually return 1 when it finds problems, only when it finds source files which don't compile (all of which are now excluded).

This also fixes existing overlooked inconsistencies as a result of this mistake.
This commit is contained in:
Chris Smowton
2020-07-09 17:46:11 +01:00
parent 302eb55d23
commit d05657ddff
11 changed files with 76 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/codeqltest.yml vendored
View File

@@ -34,7 +34,7 @@ jobs:
run: env PATH=$PATH:$HOME/codeql make
- name: Check that all QL and Go code is autoformatted
run: env PATH=$PATH:$HOME/codeql make QL_AUTOFORMAT=--check-only GO_AUTOFORMAT=-d autoformat
run: env PATH=$PATH:$HOME/codeql make check-formatting
- name: Test
run: env PATH=$PATH:$HOME/codeql make test