hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Simplify chained configs

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2020-10-23 14:52:47 +02:00
parent f87845b1ec
commit cf8462fa58
1 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
python/ql/src/experimental/Security-new-dataflow/CWE-022/ChainedConfigs12.qll
View File

@@ -12,24 +12,20 @@ import experimental.dataflow.TaintTracking
import experimental.dataflow.TaintTracking2 import experimental.dataflow.TaintTracking2
/** /**
* A `ControlFlowNode` that appears as a sink in Config1 and a source in Config2. * A `DataFlow::Node` that appears as a sink in Config1 and a source in Config2.
*/ */
private predicate crossoverNode(ControlFlowNode n) { private predicate crossoverNode(DataFlow::Node n) {
exists(DataFlow::Node n1, DataFlow2::Node n2 | any(TaintTracking::Configuration t1).isSink(n) and
any(TaintTracking::Configuration t1).isSink(n1) and any(TaintTracking2::Configuration t2).isSource(n)
any(TaintTracking2::Configuration t2).isSource(n2) and
n = n1.asCfgNode() and
n = n2.asCfgNode()
)
} }
/** /**
* A new type which represents the union of the two sets of nodes. * A new type which represents the union of the two sets of nodes.
*/ */
private newtype TCustomPathNode = private newtype TCustomPathNode =
Config1Node(DataFlow::PathNode node1) { not crossoverNode(node1.getNode().asCfgNode()) } or Config1Node(DataFlow::PathNode node1) { not crossoverNode(node1.getNode()) } or
Config2Node(DataFlow2::PathNode node1) { not crossoverNode(node1.getNode().asCfgNode()) } or Config2Node(DataFlow2::PathNode node1) { not crossoverNode(node1.getNode()) } or
CrossoverNode(ControlFlowNode e) { crossoverNode(e) } CrossoverNode(DataFlow::Node e) { crossoverNode(e) }
/** /**
* A class representing the set of all the path nodes in either config. * A class representing the set of all the path nodes in either config.
@@ -37,12 +33,12 @@ private newtype TCustomPathNode =
class CustomPathNode extends TCustomPathNode { class CustomPathNode extends TCustomPathNode {
/** Gets the PathNode if it is in Config1. */ /** Gets the PathNode if it is in Config1. */
DataFlow::PathNode asNode1() { DataFlow::PathNode asNode1() {
this = Config1Node(result) or this = CrossoverNode(result.getNode().asCfgNode()) this = Config1Node(result) or this = CrossoverNode(result.getNode())
} }
/** Gets the PathNode if it is in Config2. */ /** Gets the PathNode if it is in Config2. */
DataFlow2::PathNode asNode2() { DataFlow2::PathNode asNode2() {
this = Config2Node(result) or this = CrossoverNode(result.getNode().asCfgNode()) this = Config2Node(result) or this = CrossoverNode(result.getNode())
} }
predicate hasLocationInfo( predicate hasLocationInfo(