mirror of
https://github.com/github/codeql.git
synced 2026-04-25 08:45:14 +02:00
Java: Address review comments.
This commit is contained in:
@@ -618,7 +618,7 @@ private MethodAccess callReturningSameType(Expr ref) {
|
||||
}
|
||||
|
||||
private SrcRefType entrypointType() {
|
||||
exists(RemoteFlowSource s, RefType t |
|
||||
exists(ThreatModelFlowSource s, RefType t |
|
||||
s instanceof DataFlow::ExplicitParameterNode and
|
||||
t = pragma[only_bind_out](s).getType() and
|
||||
not t instanceof TypeObject and
|
||||
@@ -629,6 +629,10 @@ private SrcRefType entrypointType() {
|
||||
}
|
||||
|
||||
private predicate entrypointFieldStep(DataFlow::Node src, DataFlow::Node sink) {
|
||||
src = DataFlow::getFieldQualifier(sink.asExpr().(FieldRead)) and
|
||||
exists(FieldRead fa |
|
||||
fa = sink.asExpr() and
|
||||
src = DataFlow::getFieldQualifier(fa) and
|
||||
not fa.getField().isStatic()
|
||||
) and
|
||||
src.getType().(RefType).getSourceDeclaration() = entrypointType()
|
||||
}
|
||||
|
||||
@@ -86,18 +86,8 @@ module ThreatModelFlowConfig implements DataFlow::ConfigSig {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* DEPRECATED: Use `ThreatModelFlowConfig` instead.
|
||||
*/
|
||||
deprecated module RemoteFlowConfig = ThreatModelFlowConfig;
|
||||
|
||||
module ThreatModelFlow = DataFlow::Global<ThreatModelFlowConfig>;
|
||||
|
||||
/**
|
||||
* DEPRECATED: Use `ThreatModelFlow` instead.
|
||||
*/
|
||||
deprecated module RemoteFlow = ThreatModelFlow;
|
||||
|
||||
/** A data flow configuration tracing flow from json data into the argument `json` of JSONP-like string `someFunctionName + "(" + json + ")"`. */
|
||||
module JsonDataFlowConfig implements DataFlow::ConfigSig {
|
||||
predicate isSource(DataFlow::Node src) { src instanceof JsonStringSource }
|
||||
|
||||
Reference in New Issue
Block a user