hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 09:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'promote-UnsignedDifferenceExpressionComparedZero' of github.com:MathiasVP/ql into promote-UnsignedDifferenceExpressionComparedZero

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2021-02-04 17:24:59 +01:00
parent 6a97d02247 161e5679a7
commit cf0e464ab9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.qhelp
View File

@@ -5,9 +5,9 @@
<overview>
<p>
This rule finds relational comparisons between the result of an unsigned subtraction and the value <code>0</code>.
Such comparisons are likely wrong as the value of an unsigned subtraction can never be negative. So the
Such comparisons are likely to be wrong as the value of an unsigned subtraction can never be negative. So the
relational comparison ends up checking whether the result of the subtraction is equal to <code>0</code>.
This is likely not what the programmer intended.
This is probably not what the programmer intended.
</p>
</overview>
<recommendation>
@@ -23,7 +23,7 @@ This is likely not what the programmer intended.
</example>
<references>
<li>CERT C Coding Standard:
<li>SEI CERT C Coding Standard:
<a href="https://wiki.sei.cmu.edu/confluence/display/c/INT02-C.+Understand+integer+conversion+rules">INT02-C. Understand integer conversion rules</a>.
</li>