hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-25 00:27:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add a negative characteristic that indicates that an endpoint was manually modeled as a neutral model.

Browse Source
This commit is contained in:
tiferet
2023-02-28 16:59:52 -08:00
parent 084f0ee57a
commit ced7a33419
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
java/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll
View File

@@ -576,3 +576,25 @@ private class TestFileCharacteristic extends LikelyNotASinkCharacteristic {
file.getAbsolutePath().matches("%/guava-testlib/%")
}
}
/**
* A negative characteristic that indicates that an endpoint was manually modeled as a neutral model.
*
* TODO: It may be possible to turn this into a NotASinkCharacteristic, pending answers to the definition of a neutral
* model (https://github.com/github/codeql-java-team/issues/254#issuecomment-1435309148).
*/
private class NeutralModelCharacteristic extends LikelyNotASinkCharacteristic {
NeutralModelCharacteristic() { this = "neutral model" }
override predicate appliesToEndpoint(DataFlow::Node n) {
exists(Callable callee, Call call, string package, string type, string name, string signature |
n.asExpr() = call.getAnArgument() and
callee = call.getCallee() and
package = callee.getDeclaringType().getPackage().getName() and
type = callee.getDeclaringType().getName() and //TODO: Will this work for inner classes? Will it produce X$Y? What about lambdas? What about enums? What about interfaces? What about annotations?
name = callee.getName() and // TODO: Will this work for constructors?
signature = paramsString(callee) and // TODO: Why are brackets being escaped (`\[\]` vs `[]`)?
neutralModel(package, type, name, signature, "manual")
)
}
}